Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated column grid styles #662

Merged
merged 7 commits into from
Sep 10, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions deprecations.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ const versionDeprecations = {
},
{
selectors: [
'.container',
'.container::before',
'.container::after',
'.columns',
'.columns::before',
'.columns::after',
'.column',
'.one-third',
'.two-thirds',
Expand Down
91 changes: 0 additions & 91 deletions docs/content/objects/layout.md

This file was deleted.

4 changes: 2 additions & 2 deletions script/test-deprecations.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ async function checkDeprecations(options = {}) {
errors.push(error)
console.log(`${X} ${error}`)
} else {
console.log(`${V} "${selector}" is deprecated!`)
console.log(`${V} "${selector}" is officially deprecated`)
}
deprecatedSelectors.push(selector)
}
Expand All @@ -75,7 +75,7 @@ async function checkDeprecations(options = {}) {
errors.push(error)
console.log(`${X} ${error}`)
} else {
console.log(`${V} "${removedSelector}" removed and deprecated!`)
// console.log(`${V} "${removedSelector}" removed and deprecated!`)
}
}

Expand Down
1 change: 1 addition & 0 deletions script/test-doc-urls.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ const exceptions = {
'/components/tables': deprecated,
'/getting_started': moved('/getting-started/contributing'),
'/getting_started/contributing': moved('/getting-started/contributing'),
'/objects/layout': removed,
'/packages': removed,
'/packages/primer': removed,
'/packages/primer-core': removed,
Expand Down
8 changes: 0 additions & 8 deletions src/layout/container.scss
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
// Fixed-width, centered column for site content.
// This will be deprecated and replaced with container-lg in future
.container {
width: $container-width;
margin-right: auto;
margin-left: auto;
@include clearfix;
}

// Handy container styles that match our breakpoints

// 544px
Expand Down
1 change: 0 additions & 1 deletion src/layout/index.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
@import "../support/index.scss";
@import "./container.scss";
@import "./columns.scss";
@import "./grid.scss";
@import "./grid-offset.scss";