Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scripts to download SNARK artifacts #166

Closed
cedoor opened this issue Feb 16, 2024 · 0 comments · Fixed by #173
Closed

Update scripts to download SNARK artifacts #166

cedoor opened this issue Feb 16, 2024 · 0 comments · Fixed by #173
Assignees
@cedoor
Labels
refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Milestone
Beta

Comments

@cedoor
Copy link
Member

cedoor commented Feb 16, 2024 •
edited
Loading

Describe the improvement you're thinking about

@zk-kit/eddsa-proof and @zk-kit/poseidon-proof are using a function (i.e. get-snark-artifacts.node.ts) to download their SNARK artifacts (i.e. .wasm/.zkey files) on NodeJS. This function has two dependencies that can actually be replaced by a few more modern native NodeJS packages that can do the same work.

Additional context

To get an idea of the code you would need, you can look at what Semaphore integrated into its V4 in this PR.
@cedoor cedoor added this to ZK-Kit Feb 16, 2024
@cedoor cedoor converted this from a draft issue Feb 16, 2024
@cedoor cedoor added the refactoring ♻️ A code change that neither fixes a bug nor adds a feature label Feb 16, 2024
@cedoor cedoor added this to the Beta milestone Feb 16, 2024
@cedoor cedoor moved this from 📋 Backlog to ♻️ Grooming in ZK-Kit Feb 16, 2024
@cedoor cedoor moved this from ♻️ Grooming to 🏗 In Progress in ZK-Kit Feb 20, 2024
@cedoor cedoor self-assigned this Feb 20, 2024
@cedoor cedoor moved this from 🏗 In Progress to 👀 In Review in ZK-Kit Feb 20, 2024
cedoor added a commit that referenced this issue Feb 20, 2024
@cedoor
refactor: use native node modules for downloading artifacts
f545903 
re #166
@cedoor cedoor mentioned this issue Feb 20, 2024
Merged
9 tasks
@cedoor cedoor linked a pull request Feb 20, 2024 that will close this issue
Native node modules for downloading artifacts #173
Merged
9 tasks
cedoor added a commit that referenced this issue Feb 20, 2024
@cedoor
docs: update artifacts urls
59c10aa 
re #166
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✔️ Done in ZK-Kit Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cedoor cedoor

Labels
refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
ZK-Kit
Status: ✔️ Done
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

Native node modules for downloading artifacts privacy-scaling-explorations/zk-kit
1 participant
@cedoor