Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0-dependency script to download SNARK artifacts #636

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Feb 15, 2024

Description

This PR removes the dependencies which were used by get-snark-artifacts.node.ts. It only uses modern native NodeJS modules now.

This also fixes an error that the @semaphore-protocol/proof package was having with NextJS v14 (download -> got were missing the electron dependency).

Related Issue(s)

Closes #635

Other information

The same code could be re-used for the ZK-Kit libraries that are using the same script.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run yarn prettier and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cedoor cedoor requested review from 0xjei and vplasencia February 15, 2024 16:20
@cedoor cedoor linked an issue Feb 15, 2024 that may be closed by this pull request
@cedoor cedoor changed the base branch from refactor/conditional-exports to feat/semaphore-v4 February 15, 2024 19:11
@cedoor cedoor merged commit a8322fd into feat/semaphore-v4 Feb 15, 2024
3 checks passed
@cedoor cedoor deleted the refactor/download-artifacts branch February 15, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependencies from script to download artifacts on NodeJS
2 participants