CLI skeletion for VLAN feature: config, show and its templates #129

justinejose91 · 2019-09-19T22:29:08Z

venkatmahalingam · 2019-09-25T03:21:17Z

src/CLI/clitree/cli-xml/interface.xml

+			>
+			<PARAM
+				name="vlan-id"
+				help="Vlan identifier(1-4094)"


any reason for not using VLAN_ID ptype?

venkatmahalingam · 2019-09-25T03:23:20Z

src/CLI/clitree/cli-xml/interface.xml

+							mode="subcommand"
+							>
+							<PARAM
+								name="vlan-id"


fix the help string...it should say trunk mode.

venkatmahalingam · 2019-09-25T03:23:57Z

src/CLI/clitree/cli-xml/interface.xml

+                            	ptype="UINT"
+                            	>
+                        	</PARAM>
+						</PARAM>


Fix the alignment...it's hard to see the tag completions.

venkatmahalingam · 2019-09-25T03:24:44Z

src/CLI/clitree/cli-xml/interface.xml

+
+			<PARAM
+				name="trunk"
+				help="Remove trunking parameters on an interface"


is it possible to add this as the MACRO?

Will take care of it in the final PR.

venkatmahalingam · 2019-09-25T03:29:56Z

src/CLI/renderer/templates/show_vlan.j2

+{% else %}
+{% if vars.update({'tagLetter':" T "}) %}{% endif %}
+{% endif %}
+{{'%-10s'|format(vars.vlanName)}}{{'%-2s'|format(vars.tagLetter)}}{{'%-10s'|format(vars.ifName)}}


We may have to use short form of interface (e.g Eth0 instead of Ethernet0 but this conflicts with "mgmt intf"), we should have the logic to combine multiple intfs in a range and show here.

Yes, I have considered that behavior similar to what we have in OS10. Need more time to investigate inorder to figure it out,I will handle it later.

Please make sure we follow the below format for "show vlan" output, for example, instead of Vlan100, use just 100 under Num column.

S6K-12# show vlan
Codes: * - Default VLAN, M - Management VLAN, R - Remote Port Mirroring VLANs,
@ ? Attached to Virtual Network
Q: A - Access (Untagged), T - Tagged
NUM Status Description Q Ports

1 Active A Eth1/1/2-1/1/3,1/1/6-1/1/8,1/1/10-1/1/32
A Po10
10 Inactive
20 Inactive
100 Inactive
200 Inactive T Eth1/1/10
S6K-12#

Yes, will take care of it. Earlier, we didn't had oper-status support.
127.0.0.1:6379> hgetall VLAN_TABLE:Vlan101

"admin_status"

"up"

"mtu"

"9100"
This is how, it was earlier.
I think broadcom added the fix for providing oper-status info as well, so I can add that in HLD and final CLI.

* [JIRA SONIC-59502] User name field in not applicable cases should be displayed as Not Applicable instead of empty. Change-Id: Ie96be7eacf13a9ebe4c9e95abbd6a88f1e47533f * [JIRA SONIC-60245] Field to display the operational value of the session timeout in the output of the show authentication clients. Change-Id: Ieddba8ac30568d55197fe1ce172b8cc208ffdc30 * [JIRA SONIC-56405] Added support for pac configuration over range of interfaces. Change-Id: I0ce68fc2497fcc45fcd0c15d6113542967d974c2 * [JIRA SONIC-61478] KLISH: add 50G AN support Signed-off-by: Dante Su <[email protected]> Change-Id: If6c05a49f18469858b66c58cd456e7b4f6a3c0e0 * [JIRA SONIC-61803] GetTablePattern ExistKeysPattern API in DB Layer - Added Statistics Change-Id: I3732e78e13881842e9394a571788abe3ab1ac337 * [JIRA SONIC-61314] go.sum update Change-Id: I7576ffc6933f9727747d3463b022c23ad7def609 * [JIRA SONIC-61807] - Model Identity as enumeration Used Enum to represent identities This will allow swagger ui to show drop-down in case of parameters. Change-Id: I8e438545d0b28c9c2ee545a2704366da512b5c74 * [JIRA SONIC-60508]: ospf neighbor details template fix Change-Id: Iee1dbdc72e02a6d23e0dfac71220843be3730ddd * [JIRA SONIC-61879] PAC - Added required changes for config knobs dymanic_vlan_enable, vlan_assign_enable. Change-Id: Ib38db8f2e9917b4261fc709e1548ea78f0196453 * [JIRA SONIC-61168] Klish support for ND config commands Change-Id: I7227cb99ecf82bddac169c3b544bd28758f40c3b * [JIRA SONIC-61223] With user added explicit snooping configuration on Vlan, actioner has called PATCH with default value for the no form of the user configuration, this has resulted in running configuration showing default value when there is no explicit configuration for the default - Fixed actioner script to trigger DELETE for the snooping configuration instead of PATCH with the default values. - Fix added in l2mcmgrd to fill snooping configuration IPC message by reading redisDB update instead of keeping separate local cache for snooping configurations which comes before snooping enable. Change-Id: I3ace4e6eca5cb7608d48bb9e3a11bb1c4976e4d9 * [JIRA SONIC-61948] - Using oc-yang for dhcp snooping trusted port configuration in Klish Change-Id: I33c811e9316b552b08cdbc12489c73806f4e3e95 * [JIRA SONIC-62134] - Corrected the sag xml order to come after vrf config Change-Id: I0d463d9d16e014d39b343d14d36ff801019017d4 * [JIRA SONIC-61997] using escap_chars option to skip '\' for special chars Change-Id: I3b654ea105931c0e3605b84ed5db560cb5e13e95 * [JIRA SONIC-62061] validating tag field of SNMP_SERVER_TARGET entry, before using it Change-Id: I504812121a85e83693d00dae76d5321583b1b7a0 * [JIRA SONIC-61168] Klish support for show command Change-Id: Ia2e6d4d8b8ae598af3cdcdbbb051bcddc8625bbc * [JIRA SONIC-62420] Added changes to not format debug logs until its enabled to speed up execuction of actioners for ACL and FBS Change-Id: Ibbad404d7f6890d03b99d63f26f9ddd36eab728d * [JIRA SONIC-61168] Klish support for modifying help string associated with config commands to make it more descriptive Change-Id: I9377ef77a093c3b0ed5269a1df874965ae6a3298 * [JIRA SONIC-60945] Show redirect ACL binding in show access-group CLI Change-Id: I56a2f7bce3a34eec51c4371210a4379ee8730589 * Fixing merge conflict Co-authored-by: Sravani Maddukuri <[email protected]> Co-authored-by: Shiva Kumar Boddula <[email protected]> Co-authored-by: Dante Su <[email protected]> Co-authored-by: Sonic Build <[email protected]> Co-authored-by: Arun Barboza <[email protected]> Co-authored-by: Sachin Holla <[email protected]> Co-authored-by: Faraaz <[email protected]> Co-authored-by: Ramachandran Sathianandan <[email protected]> Co-authored-by: sonicmergeuser <[email protected]> Co-authored-by: sudhanshukumar22 <[email protected]> Co-authored-by: Ashok Krishnegowda <[email protected]> Co-authored-by: Akhilesh Samineni <[email protected]> Co-authored-by: suresh-rupanagudi <[email protected]> Co-authored-by: Lakshmi Sruthy <[email protected]> Co-authored-by: Abhishek Dharwadkar <[email protected]> Co-authored-by: SONiC Syncbot <[email protected]>

justinejose91 and others added 2 commits September 19, 2019 15:23

CLI skeletion for VLAN feature: config, show and its templates

2fdee4b

Changes for supporting show command with dummy data

77a8dff

justinejose91 requested review from jeff-yin, sameerdell and SrihariMandava September 20, 2019 02:37

Tejaswi-Goel mentioned this pull request Sep 20, 2019

CLI skeleton for Port channel #134

Merged

venkatmahalingam reviewed Sep 25, 2019

View reviewed changes

justinejose91 added 3 commits September 24, 2019 22:10

Addressing the comments mentioned

da35b70

Fixed alignment of XML files

4cdb8c5

Cleanup of the xml files

d5d6b80

venkatmahalingam approved these changes Sep 25, 2019

View reviewed changes

kwangsuk merged commit 1e06004 into master Sep 25, 2019

jeff-yin deleted the vlan_cli_skeleton branch September 13, 2023 22:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLI skeletion for VLAN feature: config, show and its templates #129

CLI skeletion for VLAN feature: config, show and its templates #129

justinejose91 commented Sep 19, 2019 •

edited

Loading

venkatmahalingam Sep 25, 2019

justinejose91 Sep 25, 2019

venkatmahalingam Sep 25, 2019

justinejose91 Sep 25, 2019

venkatmahalingam Sep 25, 2019

justinejose91 Sep 25, 2019

venkatmahalingam Sep 25, 2019

justinejose91 Sep 25, 2019

venkatmahalingam Sep 25, 2019

justinejose91 Sep 25, 2019 •

edited

Loading

venkatmahalingam Sep 25, 2019

justinejose91 Sep 25, 2019 •

edited

Loading

CLI skeletion for VLAN feature: config, show and its templates #129

CLI skeletion for VLAN feature: config, show and its templates #129

Conversation

justinejose91 commented Sep 19, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinejose91 Sep 25, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinejose91 Sep 25, 2019 • edited Loading

Choose a reason for hiding this comment

justinejose91 commented Sep 19, 2019 •

edited

Loading

justinejose91 Sep 25, 2019 •

edited

Loading

justinejose91 Sep 25, 2019 •

edited

Loading