CLI skeleton for Port channel #134
Conversation
Tejaswi-Goel
force-pushed
the
cli-portChannel
branch
4 times, most recently
from
b92299e to
8f6ffe7
Compare
Signed-off-by: Tejaswi Goel <[email protected]>
Tejaswi-Goel
force-pushed
the
cli-portChannel
branch
from
8f6ffe7 to
fffeffc
Compare
Tejaswi-Goel
force-pushed
the
cli-portChannel
branch
from
854584a to
b9cf2c2
Compare
Signed-off-by: Tejaswi Goel <[email protected]>
Tejaswi-Goel
force-pushed
the
cli-portChannel
branch
from
b9cf2c2 to
006737e
Compare
…ramework into cli-portChannel Signed-off-by: Tejaswi Goel <[email protected]>
| <PARAM | ||
| name="min-links" | ||
| help="Configure the minimum number of links in a port-channel" | ||
| ptype="UINT" /> |
There was a problem hiding this comment.
Do we know max. no. of ports that can be added to port-channel?
Tejaswi-Goel
force-pushed
the
cli-portChannel
branch
9 times, most recently
from
0f836f7 to
e15b277
Compare
| <PTYPE | ||
| name="LAG_ID" | ||
| method="integer" | ||
| pattern="0..9999" |
There was a problem hiding this comment.
Does it have to be 1..128? Please confirm.
There was a problem hiding this comment.
I initially had it 1..128, but then I found out on Sonic NOS the allowed range is '<0-9999>'
| help="LAG status and configuration" | ||
| ptype="SUBCOMMAND" | ||
| mode="subcommand" /> | ||
| <COMMAND |
There was a problem hiding this comment.
Better to add PARAM as summary and keep optional="true", rather than adding every PARAM as separate command.
There was a problem hiding this comment.
Done it like this here so that summary option selected or not, it is part of command on pressing enter
| help="Configure port channel parameters" | ||
| ptype="SUBCOMMAND" | ||
| mode="subcommand"/> | ||
| <COMMAND |
There was a problem hiding this comment.
Same here, make command as "channel-group" and "mode", "active" as nested PARAMs.
Tejaswi-Goel
force-pushed
the
cli-portChannel
branch
from
e15b277 to
68a6fc1
Compare
Signed-off-by: Tejaswi Goel <[email protected]>
Tejaswi-Goel
force-pushed
the
cli-portChannel
branch
from
68a6fc1 to
7a257f7
Compare
|
@justinejose91 -- please review latest changes; will hold merge until your approval |
Signed-off-by: Tejaswi Goel <[email protected]>
| @@ -162,10 +193,23 @@ limitations under the License. | |||
| ptype="VLAN_ID" | |||
| /> | |||
| </PARAM> | |||
| <PARAM | |||
| name="port-channel" | |||
There was a problem hiding this comment.
Before merging, need one thing to get clarified. "port-channel" is represented as PortChannel in Kernel, so need to get confirmation on what naming convention we go for interface name commands. Say for Interface, we go as Ethernet . I guess it would be better to go with the same name for CLI command. Let me confirm with Joyas, will get back soon.
There was a problem hiding this comment.
Just talked with @joyas-joseph , lets have the name "PortChannel" (name used in Kernel) to be consistent across all the CLI. Sorry for not pointing this out earlier. I did it wrong for vlan too, I will fix it.
| @@ -139,6 +153,23 @@ limitations under the License. | |||
| <ACTION builtin="clish_nop"></ACTION> | |||
| </COMMAND> | |||
|
|
|||
| <COMMAND | |||
| name="interface port-channel" | |||
There was a problem hiding this comment.
Example, it has to be interface PortChannel
Note: This PR to be merged after #129 PR is merged as the code for port-channel is developed on top of Vlan's code.Signed-off-by: Tejaswi Goel [email protected]