This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
Release: v0.2.0 #20
Merged
Release: v0.2.0 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Created a more MVC (model, view, controller) based program. The structure is better readable and easier to change in the future. Also added two new buttons to simulate the rocker switch input and reordered the button layout to be more logical. The model of the MVC has not been separately created because this GUI is relatively easy and an extra file would only make it less readable. * Removed the deprecated files and changed the reference of the GUI in the plugin to the newly created program. * Fixed flake8 errors * changed the rocker switch publish to use the increment or decrement variable. * Added the new gait instruction msg variable to send feedback on incrementing and decrementing using the rocker switch. Co-authored-by: Olav de Haas <[email protected]>
Olavhaasie
requested review from
JorisWeeda and
RutgerVanBeek
and removed request for
a team
Roelemans
approved these changes
Jan 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes