Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing c.browser.Incognito() to c.browser.MustConnect() to enable authenticated crawling (#209) #227

Closed
parthmalhotra opened this issue Dec 9, 2022 · 1 comment · Fixed by #228
Closed

Changing c.browser.Incognito() to c.browser.MustConnect() to enable authenticated crawling (#209) #227

parthmalhotra opened this issue Dec 9, 2022 · 1 comment · Fixed by #228
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone
katana v0.0.3

Comments

@parthmalhotra
Copy link
Member

Preparing to implement #209
https://github.com/projectdiscovery/katana/blob/main/pkg/engine/hybrid/hybrid.go#LL164C2-L164C18
@parthmalhotra parthmalhotra added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Dec 9, 2022
@parthmalhotra
Copy link
Member Author

@ehsandeep : please change the label from bug to enhancement

parthmalhotra added a commit to parthmalhotra/katana that referenced this issue Dec 9, 2022
@parthmalhotra
Changing c.browser.Incognito() to c.browser.MustConnect() to enable a…
7e929a9 
…uthenticated crawling (projectdiscovery#227)

Changing c.browser.Incognito() to c.browser.MustConnect() to enable authenticated crawling projectdiscovery#227
@parthmalhotra parthmalhotra mentioned this issue Dec 9, 2022
Merged
@ehsandeep ehsandeep added Type: Enhancement Most issues will probably ask for additions or changes. and removed Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Dec 9, 2022
@ehsandeep ehsandeep linked a pull request Dec 9, 2022 that will close this issue
Using MustConnect() instead of Incognito() in headless mode #228
Merged
ehsandeep added a commit that referenced this issue Dec 28, 2022
@parthmalhotra @ehsandeep @Mzack9999
Using MustConnect() instead of Incognito() in headless mode (#228)
38727ec 
* Added SECURITY.md

* Fix licence typo (#212)

* Changing c.browser.Incognito() to c.browser.MustConnect() to enable authenticated crawling (#227)

Changing c.browser.Incognito() to c.browser.MustConnect() to enable authenticated crawling #227

* c.browser.MustConnect() only returns 1 value

c.browser.MustConnect() only returns 1 value

* refactoring code with new no-incognito flag

Co-authored-by: Sandeep Singh <[email protected]>
Co-authored-by: Mzack9999 <[email protected]>
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Dec 28, 2022
@ehsandeep ehsandeep added this to the Katana v0.0.3 milestone Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
katana v0.0.3
Development

Successfully merging a pull request may close this issue.

Using MustConnect() instead of Incognito() in headless mode parthmalhotra/katana
2 participants
@ehsandeep @parthmalhotra