Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using MustConnect() instead of Incognito() in headless mode #228

Merged
merged 7 commits into from
Dec 28, 2022

Conversation

parthmalhotra
Copy link
Member

…uthenticated crawling (#227)

Changing c.browser.Incognito() to c.browser.MustConnect() to enable authenticated crawling #227

@ehsandeep ehsandeep changed the base branch from main to dev December 9, 2022 07:44
c.browser.MustConnect() only returns 1 value
@ehsandeep ehsandeep changed the title Changing c.browser.Incognito() to c.browser.MustConnect() to enable a… Using Incognito() instead of MustConnect() Dec 27, 2022
@ehsandeep ehsandeep changed the title Using Incognito() instead of MustConnect() Using Incognito() instead of MustConnect() in headless mode Dec 27, 2022
@ehsandeep ehsandeep requested a review from Mzack9999 December 27, 2022 20:07
@Mzack9999 Mzack9999 changed the title Using Incognito() instead of MustConnect() in headless mode Using MustConnect() instead of Incognito() in headless mode Dec 28, 2022
@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Dec 28, 2022
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - made the behavior optional via -no-incognito flag

@ehsandeep ehsandeep merged commit 38727ec into projectdiscovery:dev Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing c.browser.Incognito() to c.browser.MustConnect() to enable authenticated crawling (#209)
3 participants