Support modules configuration #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any maintainer/reviewers for this repo? Maybe cc @SuperQ? |
|
Sorry I missed this review ping. This is a great idea. I'll give it a look over asap. |
SuperQ
reviewed
May 22, 2022
rustycl0ck
reviewed
May 23, 2022
SuperQ
requested changes
May 23, 2022
|
I have updated the doc. PTAL. |
added 3 commits
May 23, 2022 22:29
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
|
Please take another look @rustycl0ck thank you! |
Closed
SuperQ
added a commit
that referenced
this pull request
Jul 3, 2022
Breaking Change: The exporter config file format has changed. It now supports multiple modules to scrape different endpoints. * [FEATURE] Support custom valuetype #145 * [FEATURE] Support modules configuration #146 Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Jul 11, 2022
Breaking Change: The exporter config file format has changed. It now supports multiple modules to scrape different endpoints. * [FEATURE] Support custom valuetype #145 * [FEATURE] Support modules configuration #146 * [FEATURE] Accept non-2xx HTTP status #161 Signed-off-by: SuperQ <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Jul 11, 2022
Breaking Change: The exporter config file format has changed. It now supports multiple modules to scrape different endpoints. * [FEATURE] Support custom valuetype #145 * [FEATURE] Support modules configuration #146 * [FEATURE] Accept non-2xx HTTP status #161 Signed-off-by: SuperQ <[email protected]>
13 tasks
teutat3s
added a commit
to teutat3s/nixpkgs
that referenced
this pull request
May 19, 2023
Upstream changed the config format in prometheus-community/json_exporter#146
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye [email protected]
Fixes #86
This PR supports modules configuration. Similar to black-box exporter, scrape requests can add a
moduleparameter to specify which module to use. If not specified,defaultmodule will be used.