Skip to content

Commit

Permalink
cli/silence_add: don't ingore errors when getting current user (#1031)
Browse files Browse the repository at this point in the history
I had a system where amtool would segfault on startup because of
that.
  • Loading branch information
iksaif authored and stuartnelson3 committed Oct 9, 2017
1 parent de24c5b commit 21a2e53
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions cli/silence_add.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,16 @@ var addCmd = &cobra.Command{
}

func init() {
user, _ := user.Current()
addCmd.Flags().StringP("author", "a", user.Username, "Username for CreatedBy field")
var username string

user, err := user.Current()
if err != nil {
fmt.Printf("failed to get the current user, specify one with --author: %v\n", err)
} else {
username = user.Username
}

addCmd.Flags().StringP("author", "a", username, "Username for CreatedBy field")
addCmd.Flags().StringP("expires", "e", "1h", "Duration of silence (100h)")
addCmd.Flags().String("expire-on", "", "Expire at a certain time (Overwrites expires) RFC3339 format 2006-01-02T15:04:05Z07:00")
addCmd.Flags().StringP("comment", "c", "", "A comment to help describe the silence")
Expand Down

0 comments on commit 21a2e53

Please sign in to comment.