cli/silence_add: don't ingore errors when getting current user #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/silence_add.go
Outdated
| user, _ := user.Current() | ||
| addCmd.Flags().StringP("author", "a", user.Username, "Username for CreatedBy field") | ||
| user, err := user.Current() | ||
| username := "" |
There was a problem hiding this comment.
as a zero value string using var username string reads better, what do u think?
iksaif
force-pushed
the
criteo
branch
2 times, most recently
from
088de56 to
46a4e74
Compare
stuartnelson3
suggested changes
Oct 6, 2017
cli/silence_add.go
Outdated
| username := "" | ||
|
|
||
| if err != nil { | ||
| fmt.Errorf("Failed to get current user") |
There was a problem hiding this comment.
This doesn't actually do anything -- it creates an error but doesn't indicate it to the user. It would be useful to let the user know that they don't have a default username available, and that they'll have to provide one (since we require an author when creating silences).
|
Ok, the error message should be correctly printed now :) |
stuartnelson3
suggested changes
Oct 6, 2017
cli/silence_add.go
Outdated
|
|
||
| user, err := user.Current() | ||
| if err != nil { | ||
| fmt.Printf("Failed to get the current user, specify one with --author: %s\n", err) |
There was a problem hiding this comment.
It's typical in go to have the first letter of a log or print statement be lowercase, so failed instead of Failed. Also, err is of type error, which is printed out with %v. Once that's done, good to go.
|
fixed |
I had a system where amtool would segfault on startup because of that.
stuartnelson3
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a system where amtool would segfault on startup because of
that.