dispatch: fix race condition in dispatch test #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's just a race in the test itself, this is not actually a race in the Alertmanager code itself. But in order to one day run all tests with the |
|
Sorry I don't think I understood your question in my previous comment. We're guarding reading/writing the |
stuartnelson3
approved these changes
Oct 4, 2017
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Aug 5, 2018
…s#1025 (prometheus#1026) Signed-off-by: Christian Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the (many) race conditions in the dispatch tests. As there are quite a few I was going to tackle them one by one. This one was a fairly obvious one.
@stuartnelson3 @fabxc