Remove .WasInhibited and .WasSilenced fields of Alert type

[brancz]

This fixes the race condition reported in #1013.

As I was fixing this, I noticed, that I couldn't find where or if this is actually used anywhere, as it's not rendered in the json response, and otherwise not used at all either. If we can confirm this we can probably remove it entirely. I know there was some work around this relatively recently, but don't remember exactly anymore what.

Fixes #1013

@stuartnelson3 @fabxc @mxinden

[brancz]

I kept testing this with real life examples, that I missed to check whether the unit tests still like the code, my bad.

But before I fix these issues, I would like to answer the question I wrote in the PR description. Are these fields actually useful for us? They seem to only be used in tests, and from what I can tell we should be able to solve their usage otherwise in the tests.

[fabxc]

Honestly, I don't quite remember. Maybe we used them in the past. But if they are unused now, we might just want to remove them until we need them again?

[josedonizetti]

+1 to remove until needed

[stuartnelson3]

Seems like it was introduced here: 4ada239#diff-e3c7390fa395ee56af39ca3c727e01b6

The only use of it in this commit is for testing, so it's probably been that way for the lifetime of the struct member. If we're not using it, might as well get rid of it.

[brancz]

I removed the .WasInhibited and .WasSilenced fields of the Alert type. The changes show that they were used nowhere except for the tests, where it was tested, that they were set.

[brancz]

@fabxc @stuartnelson3 @josedonizetti PTAL :)