Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing CPU, Load and Storage OIDs #154

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

jayme-github
Copy link
Contributor

Sorry @brian-brazil - I missed some. 🙁

@brian-brazil brian-brazil merged commit 6639809 into prometheus:master Apr 25, 2017
@brian-brazil
Copy link
Contributor

Thanks!

@Svedrin
Copy link

Svedrin commented Apr 25, 2017

this is a bit odd... I tried to add the very same metrics to SNMP exporter a while back so I could scrape my linux boxes more easily which have snmpd deployed already, without needing to deploy node_exporter everywhere. So now I just need to tell snmp_exporter that everything's a Synology NAS and it'll happily scrape the values for me? that doesn't sound right :/ maybe the CPU and storage parts could be split out into a more generic module?

@brian-brazil
Copy link
Contributor

If you can use the node exporter you should. SNMP is inferior in many many ways.

@juliusv
Copy link
Member

juliusv commented Apr 25, 2017

The context on IRC from @Svedrin was:

when I proposed to add disk/cpu metrics to snmp-exporter that proposal was rejected due to "we want you to use node-exporter for that" reasons, but now the very same metrics have been added to the synology module... so I just have to tell snmp-exporter that my linux box is a synology NAS and it'll happily scrape the values for me?

So I guess the question was why allow CPU/disk metrics for Synology, but not for other things. Is it not possible to run node exporter on Synology? Just wondering about the consistency of the decision.

@SuperQ
Copy link
Member

SuperQ commented Apr 25, 2017

I originally suggested that using the node_exporter on the Synology was the best path. Using SNMP for this is not what I would recommend.

SuperQ added a commit to SuperQ/snmp_exporter that referenced this pull request Jun 6, 2017
* [FEATURE] Add Homepage on /. prometheus#135
* [IMPROVEMENT] Add ddwrt OIDs to generator. prometheus#147
* [IMPROVEMENT] Add synology OIDs to generator. prometheus#149, prometheus#154
* [IMPROVEMENT] Use lookup node's index label in the generator. prometheus#162
* [BUGFIX] Fix `authNoPriv` in config parsing. prometheus#141
* [BUGFIX] Update gosnmp vendoring to fix timeouts/errors. prometheus#139, prometheus#171
@SuperQ SuperQ mentioned this pull request Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants