Update generator #162
Merged
Update generator #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the literal name from the generator's config, use the Label from the MIB index. This allows OIDs to be used in the `new_index` field in the generator.yml.
generator/generator.yml
Outdated
| @@ -10,7 +10,7 @@ modules: | |||
| walk: [sysUpTime, interfaces, ifXTable] | |||
| lookups: | |||
| - old_index: ifIndex | |||
| new_index: ifName | |||
| new_index: 1.3.6.1.2.1.31.1.1.1.1 # ifName | |||
There was a problem hiding this comment.
This should have a comment as to why we're doing this
| @@ -195,14 +195,14 @@ func generateConfigModule(cfg *ModuleConfig, node *Node, nameToNode map[string]* | |||
| } | |||
| indexNode := nameToNode[lookup.NewIndex] | |||
| // Avoid leaving the old labelname around. | |||
| index.Labelname = lookup.NewIndex | |||
| index.Labelname = indexNode.Label | |||
There was a problem hiding this comment.
This change should have a unittest
There was a problem hiding this comment.
Added a test for OID-based lookups.
This avoids the ifName conflict caused by the Citrix netscaler NS-ROOT-MIB module.
This updates with the latest generator code, removes non-accessible metrics from being used.
SuperQ
added a commit
to SuperQ/snmp_exporter
that referenced
this pull request
Jun 6, 2017
* [FEATURE] Add Homepage on /. prometheus#135 * [IMPROVEMENT] Add ddwrt OIDs to generator. prometheus#147 * [IMPROVEMENT] Add synology OIDs to generator. prometheus#149, prometheus#154 * [IMPROVEMENT] Use lookup node's index label in the generator. prometheus#162 * [BUGFIX] Fix `authNoPriv` in config parsing. prometheus#141 * [BUGFIX] Update gosnmp vendoring to fix timeouts/errors. prometheus#139, prometheus#171
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use lookup node's index label in the generator:
Label from the MIB index. This allows OIDs to be used in the
new_indexfield in the generator.yml.Use an explicit OID for ifName lookups.
Update snmp.yml
metrics from being used.
Misc: