pronto doesn't analyse staged changes

[konradstrack]

I've been trying to execute pronto in a pre-commit hook, and I ended up with the following issue.

Suppose I have a file with inorrect indentation: in this case it's Gemfile. I stage it with git add Gemfile and execute pronto run --index. No issues are reported.

Now, if I do git reset Gemfile, pronto run --index will report the issues correctly, e.g.:

Gemfile:166 I: Inconsistent indentation detected.
Gemfile:167 I: Tab detected.
Gemfile:167 I: Inconsistent indentation detected.
Gemfile:168 I: Tab detected.
Gemfile:168 I: Inconsistent indentation detected.

I tested a bit more, and staged changes are not being analysed with all of the following:
pronto run,
pronto run --index,
pronto run --commit=$(git log --pretty=format:%H | head -1),
pronto run --commit=HEAD.

Is there something trivial I have missed, or is this behaviour expected?

I used Ruby 2.1.5. More info:

    pronto (0.5.3)
      gitlab (~> 3.4.0)
      octokit (~> 4.1.0)
      rugged (~> 0.23.0)
      thor (~> 0.19.0)
    pronto-flay (0.5.0)
      flay (~> 2.6.0)
      pronto (~> 0.5.0)
    pronto-jshint (0.5.0)
      jshintrb (~> 0.3.0)
      pronto (~> 0.5.0)
    pronto-rails_best_practices (0.5.0)
      pronto (~> 0.5.0)
      rails_best_practices (~> 1.15.0)
    pronto-rails_schema (0.5.0)
      pronto (~> 0.5.0)
    pronto-rubocop (0.5.0)
      pronto (~> 0.5.0)
      rubocop (~> 0.35.0)

[mmozuras]

@konradstrack I've created an issue on rugged repo.

[mmozuras]

Changing this from bug to enhancement. You can follow the discussion here:

libgit2/rugged#548

Will make it part of the next release, because an integration with overcommit would be great.

[elliotthilaire]

I've also come across this issue.
Is this something I can help with?

[KirillSuhodolov]

• will be great have integration with overcommit

[MvanDiemen]

@mmozuras any update on how to use this with staged changes?

[mmozuras]

@konradstrack @elliotthilaire @KirillSuhodolov @MvanDiemen I've renamed the --index option to --unstaged and added --staged options as requested with this commit. You can test it by building master and installing master locally. Would love feedback 😄

[mmozuras]

@KirillSuhodolov @glennr you can find the PR on Overcommit for a pre-commit hook here: sds/overcommit#488 😄