Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pronto not showing staged changes #214

Closed
MvanDiemen opened this issue Mar 20, 2017 · 1 comment
Closed

Pronto not showing staged changes #214

MvanDiemen opened this issue Mar 20, 2017 · 1 comment
Labels

Comments

@MvanDiemen
Copy link

A continuation of #111.

I am using the master branch with the fix included in the previous issue, but it's not showing anything.

~/r/nfr:cleanup/introduce-pronto> bundle show pronto
/home/michael/.gem/ruby/2.3.1/bundler/gems/pronto-037afde01882
~/r/nfr:cleanup/introduce-pronto> git diff app
diff --git a/app/controllers/backend/contracts_controller.rb b/app/controllers/backend/contracts_controller.rb
index 48c55a963..cdf793393 100644
--- a/app/controllers/backend/contracts_controller.rb
+++ b/app/controllers/backend/contracts_controller.rb
@@ -71,6 +71,10 @@ class Backend::ContractsController < InheritedResources::Base
     render
   end
 
+  def ThisMethodFails
+    'foo' == true ? true == false ? raise StandardError, "Foo" : nil : nil
+  end
+
   def export_to_excel_bang
 
~/r/nfr:cleanup/introduce-pronto> bundle exec pronto run --unstaged
app/controllers/backend/contracts_controller.rb:75 E: dynamic constant assignment
(Using Ruby 2.3 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
app/controllers/backend/contracts_controller.rb:75 E: unexpected token tCONSTANT
(Using Ruby 2.3 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
~/r/nfr:cleanup/introduce-pronto> git add app
~/r/nfr:cleanup/introduce-pronto> git diff --cached app
diff --git a/app/controllers/backend/contracts_controller.rb b/app/controllers/backend/contracts_controller.rb
index 48c55a963..cdf793393 100644
--- a/app/controllers/backend/contracts_controller.rb
+++ b/app/controllers/backend/contracts_controller.rb
@@ -71,6 +71,10 @@ class Backend::ContractsController < InheritedResources::Base
     render
   end
 
+  def ThisMethodFails
+    'foo' == true ? true == false ? raise StandardError, "Foo" : nil : nil
+  end
+
   def export_to_excel_bang
 
~/r/nfr:cleanup/introduce-pronto> bundle exec pronto run --staged
~/r/nfr:cleanup/introduce-pronto> 
@mmozuras mmozuras added the bug label Apr 8, 2017
@mmozuras
Copy link
Member

@MvanDiemen my mistake! I only tested whether patches exist, not the whole integration. Fixed now 😄.

P.S. It was a fun bug to figure out and fix 😄.

apiology pushed a commit to apiology/pronto that referenced this issue Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants