Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gem version to 0.11.0 #385

Closed
wants to merge 1 commit into from

Conversation

RGBD
Copy link
Contributor

@RGBD RGBD commented Jun 27, 2020

Solves #376. @mknapik you've been pretty active recently in merging pull requests.
Maybe you know what else needs to be done before new gem version release?

@RGBD RGBD requested a review from a team as a code owner June 27, 2020 10:33
@RGBD RGBD changed the title Update version.rb Update gem version to 0.11.0 Jun 27, 2020
@RGBD RGBD force-pushed the bump-gem-version-0.11.0 branch from 4a8df8e to 1be0e4a Compare June 27, 2020 10:55
@RGBD
Copy link
Contributor Author

RGBD commented Jul 28, 2020

Seems like I'll also have to update pronto-rubocop version to make it work, or update to 0.10.1 but I don't know if master contains breaking changes at the moment.
@mmozuras, @doomspork, @aergonaut , who can I discuss that with?

@doomspork
Copy link
Member

doomspork commented Jul 28, 2020

Howdy @RGBD I am going to start working through these releases this week. Thanks for helping with this. 👍

I do not believe Master has any breaking changes

@RGBD
Copy link
Contributor Author

RGBD commented Jul 30, 2020

Thanks for the feedback
@doomspork , does it mean we should update to 0.10.1 instead, so that pronto-rubocop is still compatible with the new pronto gem version?

@ashkulz
Copy link
Member

ashkulz commented Jul 31, 2020

Would appreciate if you update CHANGELOG.md here itself, @RGBD 🙂

I think we've had enough new features since 0.10.0 to call it 0.11.0 -- we can always make a new release for pronto-rubocop, but I'm not sure if @doomspork has access to release that gem?

@RGBD
Copy link
Contributor Author

RGBD commented Jul 31, 2020

@ashkulz, alas I don't watch this repo history closely enough to know about all the features, so I've mentioned only the one imortant for me (GitLab MR reviews).
Should I add to changelog every major merge request that happened since last mentioned in the changelog currently (feature #331, bug fix #329)?

@ashkulz
Copy link
Member

ashkulz commented Oct 28, 2020

Sorry for the long delay, but I think yes, that'd be great. I'm still not sure who has access to releasing gems, though.

@RGBD RGBD force-pushed the bump-gem-version-0.11.0 branch from 0015d7f to bc72564 Compare November 10, 2020 21:27
@RGBD RGBD force-pushed the bump-gem-version-0.11.0 branch from bc72564 to 3db0874 Compare November 10, 2020 21:28
@RGBD
Copy link
Contributor Author

RGBD commented Nov 10, 2020

Done, @ashkulz.
What's the next step?
Should I also bump pronto-rubocop version?

@ashkulz
Copy link
Member

ashkulz commented Nov 22, 2020

@doomspork?

@smridge
Copy link

smridge commented Nov 23, 2020

To get master to work I had to run brew install cmake pkg-config for the rugged dependency. Perhaps this would be good to mention in the README. This will also break CI builds that use pronto.

@ashkulz
Copy link
Member

ashkulz commented Nov 24, 2020

@smridge I think that's been a requirement for quite a while, even 0.10.0 depended on rugged.

@smridge
Copy link

smridge commented Nov 24, 2020

@smridge I think that's been a requirement for quite a while, even 0.10.0 depended on rugged.

Ahh ok. Tried it out on a new repo, so that makes sense why I’m seeing all the fun.

@ashkulz ashkulz requested a review from doomspork December 10, 2020 08:44
@RGBD
Copy link
Contributor Author

RGBD commented Dec 30, 2020

@doomspork, is there any approximate date when this could be reviewed/merged?

@ashkulz
Copy link
Member

ashkulz commented Jan 6, 2021

I've been granted permissions to publish to RubyGems by @doomspork, so I'll try working towards a release by the weekend (unless he has any feedback, of course 🙂).

@doomspork
Copy link
Member

Howdy @RGBD and @ashkulz 👋 My apologizes, this was lost in my ever growing notification list 😰

I think 0.11 seems like a sufficient bump. I don't see any reason to consider this a major or patch.

@doomspork
Copy link
Member

doomspork commented Jan 6, 2021

Something to add to this (given this particular PR), I think we should investigate some of the semantic versioning tools that will handle publishing gems for us as features as added. The biggest change we'll need to make is ensuring PRs update the version accordingly (when necessary) and the changelog.

Automating the release of these packages would greatly reduce the maintenance burden across so many different projects.

https://github.com/semantic-release/semantic-release

@ashkulz ashkulz closed this in ac357c6 Jan 31, 2021
@ashkulz
Copy link
Member

ashkulz commented Jan 31, 2021

Thanks for the contribution, @RGBD! I went through the git log and added a few other PRs to the changelog, but added you as a co-author in the above commit 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants