Unreasonable use of JSON_FORCE_OBJECT in PersistenceStrategies' implementations

[afoeder]

In every implementation of \Prooph\EventStore\Pdo\PersistenceStrategy::prepareData there are json_encode occurrences with the JSON_FORCE_OBJECT flag set:

public function prepareData(Iterator $streamEvents): array
    {
        $data = [];

        foreach ($streamEvents as $event) {
            $data[] = $event->uuid()->toString();
            $data[] = $event->messageName();
            $data[] = json_encode($event->payload(), \JSON_FORCE_OBJECT);
            $data[] = json_encode($event->metadata(), \JSON_FORCE_OBJECT);
            $data[] = $event->createdAt()->format('Y-m-d\TH:i:s.u');
        }

        return $data;
    }

This results in plain arrays being handled like objects, i.e. array('hoo', 'ray') results in {"0":"hoo","1":"ray"}" (3v4l example)

From the PHP docs:

JSON_FORCE_OBJECT Outputs an object rather than an array when a non-associative array is used. Especially useful when the recipient of the output is expecting an object and the array is empty. Available since PHP 5.3.0.

Please reconsider its necessity.

// additional note: decoding it back with second argument (assoc) true will restore a properly indexed array: https://3v4l.org/Brr7i

[bweston92]

@afoeder unfortunately PHPUnit thinks it is fine because the keys match. See #91

[afoeder]

I disagree with closing it. Just because no presently existing unit test fails or changes doesn't mean the implementation ist correct.
It coincidentally works when reconstituting from the database, but the intermediate format is incorrect as a matter of fact and I propose fixing it...

[prolic]

It's already fixed with v1.3.1 incl tests.

…

On Jun 23, 2017 22:12, "Adrian Föder" ***@***.***> wrote: I disagree with closing it. Just because no presently existing unit test fails or changes doesn't mean the implementation ist correct. It *coincidentally* works when reconstituting from the database, but the intermediate format is incorrect as a matter of fact and I propose fixing it... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#87 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYEvJu-RZZD0DBSrjeXhzjPH9RMdsU2ks5sG8fogaJpZM4OAs9j> .

[afoeder]

sorry @prolic, read that via mobile and didn't see it was closed through #93. Thank you!