Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JSON_FORCE_OBJECT #93

Merged
merged 4 commits into from
Jun 22, 2017
Merged

Remove JSON_FORCE_OBJECT #93

merged 4 commits into from
Jun 22, 2017

Conversation

prolic
Copy link
Member

@prolic prolic commented Jun 22, 2017

resolves #87

@prolic prolic changed the title Remove Json force object Remove JSON_FORCE_OBJECT Jun 22, 2017
@codeliner
Copy link
Member

LGTM but travis failed

@prolic
Copy link
Member Author

prolic commented Jun 22, 2017

that should do the trick, I hope travis is green now

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.868% when pulling 5fd9725 on json_force_object into 62c45f0 on master.

@codeliner codeliner merged commit 4a946b7 into master Jun 22, 2017
@codeliner codeliner deleted the json_force_object branch June 22, 2017 16:34
@afoeder afoeder mentioned this pull request Jun 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeliner codeliner codeliner approved these changes

Assignees

@codeliner codeliner

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unreasonable use of JSON_FORCE_OBJECT in PersistenceStrategies' implementations
3 participants
@prolic @codeliner @coveralls