Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Secure gRPC Connections by Default #366

Closed
prestonvanloon opened this issue Aug 2, 2018 · 2 comments
Closed

Support Secure gRPC Connections by Default #366

prestonvanloon opened this issue Aug 2, 2018 · 2 comments
Labels
Help Wanted Extra attention is needed
Milestone

Comments

@prestonvanloon
Copy link
Member

PR #364 introduces gRPC server connection through insecure connections.

https://github.com/prysmaticlabs/prysm/pull/364/files#diff-6df2af9c5a6ba83c50b7b5ec427fba94R39

We should do the following:

  • Add flag to specify insecure connections (--use_insecure_rpc or similiar) where the default is secure connection
  • Warning that this is an insecure connection
  • Support TLS secure connections provided by the server through letsencrypt.org or similar

There may be multiple gRPC server/client connections. This issue should capture all of those cases.

@prestonvanloon prestonvanloon added this to the Diamond milestone Aug 2, 2018
@prestonvanloon prestonvanloon added Help Wanted Extra attention is needed Intermediate labels Aug 4, 2018
0xKiwi pushed a commit to 0xKiwi/prysm that referenced this issue Aug 7, 2018
0xKiwi pushed a commit to 0xKiwi/prysm that referenced this issue Aug 8, 2018
@rauljordan
Copy link
Contributor

Can this be closed @prestonvanloon ?

@prestonvanloon
Copy link
Member Author

Yes. The default would require to ship with a certificate of some kind. We have a WARN level logging to communicate that the connection is insecure for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants