Beacon Node gRPC Server and Client Services #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ethereum prefix for proto package
terencechain
reviewed
Aug 1, 2018
beacon-chain/utils/flags.go
Outdated
| @@ -26,4 +26,10 @@ var ( | |||
| Name: "pubkey", | |||
| Usage: "Validator's public key. Beacon chain node will listen to VRC log to determine when registration has completed based on this public key address.", | |||
| } | |||
| // BeaconRPCPort defines a beacon node RPC port to open. | |||
| BeaconRPCPort = cli.StringFlag{ | |||
| Name: "beacon-rpc-port", | |||
There was a problem hiding this comment.
Let's think the name here, do we really need beacon? If a beacon code only opens up one kind of rpc port, it should just be rpc-port right?
There was a problem hiding this comment.
Good point, will change
beacon-chain/rpc/service.go
Outdated
|
|
||
| var log = logrus.WithField("prefix", "rpc") | ||
|
|
||
| // Service hi. |
There was a problem hiding this comment.
Is there a reason we put hi there? and for all the comments too
There was a problem hiding this comment.
Whoops, forgot to change lol
terencechain
reviewed
Aug 1, 2018
beacon-chain/main.go
Outdated
| @@ -58,7 +58,7 @@ VERSION: | |||
| app.Usage = "this is a beacon chain implementation for Ethereum 2.0" | |||
| app.Action = startNode | |||
|
|
|||
| app.Flags = []cli.Flag{utils.SimulatorFlag, utils.VrcContractFlag, utils.PubKeyFlag, utils.Web3ProviderFlag, cmd.DataDirFlag, cmd.VerbosityFlag, debug.PProfFlag, debug.PProfAddrFlag, debug.PProfPortFlag, debug.MemProfileRateFlag, debug.CPUProfileFlag, debug.TraceFlag} | |||
| app.Flags = []cli.Flag{utils.SimulatorFlag, utils.VrcContractFlag, utils.PubKeyFlag, utils.Web3ProviderFlag, utils.BeaconRPCPort, cmd.DataDirFlag, cmd.VerbosityFlag, debug.PProfFlag, debug.PProfAddrFlag, debug.PProfPortFlag, debug.MemProfileRateFlag, debug.CPUProfileFlag, debug.TraceFlag} | |||
There was a problem hiding this comment.
We should change BeaconRPCPort to RPCPort too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This implements a beacon node gRPC server as a service alongside a gRPC client for a sharding client and beacon node to communicate effectively. Setting this up is important for us to deprecate the Sharding Manager Contract and update our client code to the latest spec. #315.
To get this working, just run the beacon node with the flag
--beacon-rpc-port 4000and a sharding client with--beacon-rpc-provider http://localhost:4000.