This repository was archived by the owner on Feb 25, 2021. It is now read-only.
Fix issue whereby files are failed to be chown'ed due to not existing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaneEveritt
suggested changes
Dec 2, 2018
| @@ -249,8 +254,10 @@ func (fs FileSystem) Filecmd(request *sftp.Request) error { | |||
|
|
|||
| // Not failing here is intentional. We still made the file, it is just owned incorrectly | |||
| // and will likely cause some issues. | |||
| if err := os.Chown(fileLocation, fs.User.Uid, fs.User.Gid); err != nil { | |||
| logger.Get().Warnw("error chowning file", zap.String("file", fileLocation), zap.Error(err)) | |||
| if !isRemoval { // We can't perform a chown on a file that has been removed | |||
There was a problem hiding this comment.
Why not just check if the request.Method is Rmdir or Remove?
|
Closed in favor of #3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to rectify the following issue: pterodactyl/panel#1380
The logs provided by CodeCo state that on line 230, chown'ing the file fails because it doesn't exist. This appears to be because the chown is run even if the file was removed. I've added code that prevents the chown from running in the case of a file or directory removal.