This repository was archived by the owner on Feb 25, 2021. It is now read-only.
Vladort fixes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix file right error, error 102400, error 0000 or ---- and file edit override fail when size of file is under existing file size
os.Create will truncate an existing file, so there is no reason to remove the file first here. Also you can't make it to that last removed point without a file existing because of the return on (now) line 114.
|
Commited a few fixes and cleaned up some logic. Overall it looks like the core issue was that the file mode being passed in from some SFTP clients was invalid, so now it uses 644 or 755 depending on the item. Not sure what exactly the issue with the file size was, could you clarify that for me? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix file right error, error 102400, error 0000 or ---- and file edit override fail when size of file is under existing file size.
I'm Golang beginner, feel free to fix whatever i made wrong.