-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minify-Image module not working #1420
Comments
Ah, good catch! Once we figure this out, let's add this to our per-module
tests so that it doesn't happen again :-)
Thank you!!!!
…On Mon, Jan 6, 2020 at 6:06 PM Rishabh Shukla ***@***.***> wrote:
[image: Screenshot from 2020-01-07 04-31-56]
<https://user-images.githubusercontent.com/42492389/71855304-aec60800-3106-11ea-89b9-f5b3747667a8.png>
Yep! As I thought culprit is most probably one of the very recent PRs as
it is still working on beta site(beta was updated on 29 Dec)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1420?email_source=notifications&email_token=AAAF6J2HIYRAFFTXPM5D4K3Q4O2NZA5CNFSM4KCX4N52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHC64I#issuecomment-571354993>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J6M6IGZIGWK4THJDR3Q4O2NZANCNFSM4KCX4N5Q>
.
|
I fixed the issue of image not showing.... but the image is not getting compressed, it is stil showing the same image... |
Try downloading the image and check its size. It is supposed to reduce the image size (like zipping or tarballing) |
I tired tried to find difference between the two images using their's base64 format....Didn't found any. |
Maybe the image cannot be compressed? I think we should check what the npm module that is used in the minify-image module, does. |
Please describe the problem (or idea)
Minify Image module is not showing the output image.
Please show us where to look
https://beta.sequencer.publiclab.org
What's your PublicLab.org username?
Browser, version, and operating system
Thank you!
Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.
To learn how to write really great issues, which increases the chances they'll be resolved, see:
https://publiclab.org/wiki/developers#Contributing+for+non-coders
The text was updated successfully, but these errors were encountered: