Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify-Image module not working #1420

Closed
root00198 opened this issue Jan 4, 2020 · 7 comments · Fixed by #1512
Closed

Minify-Image module not working #1420

root00198 opened this issue Jan 4, 2020 · 7 comments · Fixed by #1512
Labels

Comments

@root00198
Copy link
Member

root00198 commented Jan 4, 2020

Please describe the problem (or idea)

Minify Image module is not showing the output image.

What happened just before the problem occurred? Or what problem could this idea solve?
bug

What did you expect to see that you didn't?
I didnt saw any output image.

Please show us where to look

https://beta.sequencer.publiclab.org

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@rishabhshuklax
Copy link
Member

This was working fine a while back maybe #1425 caused this?
cc: @jywarren

@rishabhshuklax
Copy link
Member

Screenshot from 2020-01-07 04-31-56

Yep! As I thought culprit is most probably one of the very recent PRs as it is still working on beta site(beta was updated on 29 Dec)

@jywarren
Copy link
Member

jywarren commented Jan 6, 2020 via email

@root00198
Copy link
Member Author

root00198 commented Jan 7, 2020

I fixed the issue of image not showing.... but the image is not getting compressed, it is stil showing the same image...

@harshkhandeparkar
Copy link
Member

Try downloading the image and check its size. It is supposed to reduce the image size (like zipping or tarballing)

@root00198
Copy link
Member Author

I tired tried to find difference between the two images using their's base64 format....Didn't found any.

@harshkhandeparkar
Copy link
Member

Maybe the image cannot be compressed? I think we should check what the npm module that is used in the minify-image module, does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants