Minify Module Image Not Showing Fix #1422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1422 +/- ##
=======================================
Coverage 66.36% 66.36%
=======================================
Files 125 125
Lines 2572 2572
Branches 406 406
=======================================
Hits 1707 1707
Misses 865 865 |
|
I just realized that the module is not working correctly.... |
| @@ -76,7 +78,7 @@ module.exports = function MinifyImage(options, UI) { | |||
| }); | |||
| var destPath = __dirname + '/results/test.' + input.format; | |||
| var data = base64Img.base64Sync(destPath); | |||
| output(data, input.format); | |||
| output(destPath, data, input.format); | |||
There was a problem hiding this comment.
Why do we do this in the browser? Why is it even required? Can't we just output the image? Was it used for debugging and was left out?
There was a problem hiding this comment.
This is used for command line interface.
There was a problem hiding this comment.
But that part is handled by the sequencer core library code anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1420 (<=== Replace
0000with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!