Add leaflet-fullHash.js .

[sagarpreet-chadha]

Continued from : #419 (comment)

Let's add leaflet-fullHash.js to mapknitter index map 🗺 .

• Add leaflet-fullHash.js to bower.json . See this for example :
  https://github.com/publiclab/leaflet-environmental-layers/blob/cb4b72824d0186bba1fa1bca1bdafff8a1742992/package.json#L46

• Incorporate this dependency in the from of script tag in view/maps/index.html.erb .
  See this for example : https://github.com/publiclab/leaflet-environmental-layers/blob/cb4b72824d0186bba1fa1bca1bdafff8a1742992/example/index.html#L47

• Add leaflet-fullHash object code in view/maps/index.html.erb , see this for example :
  https://github.com/publiclab/leaflet-environmental-layers/blob/cb4b72824d0186bba1fa1bca1bdafff8a1742992/example/index.html#L333

We currently use this library in Leaflet environmental Layers and plots2 😄 . Lets use this in mapknitter as well 🎈 !

[divyabaid16]

Can I help here?

[sagarpreet-chadha]

Yes please , go ahead !!! Thank you :)

[igniteeng000]

Hi @sagarpreet-chadha . I have already solved this issue, Please check #501.

[igniteeng000]

But, I have added leaflet hash instead of leaflet-full Hash. I will send another PR soon.

[divyabaid16]

Oops!!
I was about to send the PR.
No problem!! I will look into other issue 😄

[grvsachdeva]

Hey @sagarpreet-chadha, the PR for the first part is up at #516, please review. Thanks!

[sashadev-sky]

@sagarpreet-chadha reopening this as point 3 has not been resolved yet. Is it still relevant and, if so,
would you like to open an FTO with the code to add the new leaflet-fullHash object?

[sagarpreet-chadha]

Opened issue #621 for solving 3rd pointer 👍

[sashadev-sky]

@sagarpreet-chadha great thank you!! i assigned it to someone already 😊

[grvsachdeva]

Solved in #891. @kaustubh-nair @alaxalves please verify. Thank you!

[sashadev-sky]

@gauravano still not positive what the problem / ideal outcome was here so you might be a better a better judge on this --- what about #621 ?? If there's anything left to merge we should do that ! And I guess if we have to close it, close it

[sashadev-sky]

@sagarpreet-chadha

[sagarpreet-chadha]

Hi @sashadev-sky ,
sorry for reverting back late.
I found something weird, mapknitter.org does not have the LEL layers!
It is in the codebase:

mapknitter/app/views/maps/index.html.erb

Line 236 in ab4727f

L.control.layers(baseMaps,overlayMaps).addTo(Mapknitterunique);

But not showing in the production .

And these lines are not working as you can check on website:

mapknitter/app/views/maps/index.html.erb

Line 123 in ab4727f

var bounds = new L.LatLngBounds(new L.LatLng(84.67351257 , -172.96875) , new L.LatLng(-54.36775852 , 178.59375)) ;

@jywarren , Is production pointing to different branch?

[jywarren]

Was it perhaps installed on some maps but not others? We should have it installed on the new View Only page that Cess is working on, for sure. And perhaps on the front page tour map. Could we integrate it with the new one-line all layers function once that is done?

…

On Wed, Aug 21, 2019 at 11:12 AM Sagarpreet Chadha ***@***.***> wrote: Hi @sashadev-sky <https://github.com/sashadev-sky> , sorry for reverting back late. I found something weird, mapknitter.org does not have the LEL layers! It is in the codebase: https://github.com/publiclab/mapknitter/blob/ab4727f085a507f469cb27ebd97f5a44b5cfe9a8/app/views/maps/index.html.erb#L236 But not showing in the production . And these lines are not working as you can check on website: https://github.com/publiclab/mapknitter/blob/ab4727f085a507f469cb27ebd97f5a44b5cfe9a8/app/views/maps/index.html.erb#L123 @jywarren <https://github.com/jywarren> , Is production pointing to different branch? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#510?email_source=notifications&email_token=AAAF6J7RSE5757LPTM3SU2DQFVLKLA5CNFSM4HEQGZD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4Z756I#issuecomment-523501305>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J3GJD5X4PPK7WT3FNDQFVLKLANCNFSM4HEQGZDQ> .

[sagarpreet-chadha]

Okay, yeah makes sense . Lets preempt integration till the new one-liner feature is ready . Thanks