Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added leaflet-hash library #501

Closed
wants to merge 1 commit into from
Closed

Conversation

igniteeng000
Copy link
Member

@igniteeng000 igniteeng000 commented Apr 7, 2019

Fixes #419 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@igniteeng000
Copy link
Member Author

@publiclab/reviewers @jywarren please review.

@igniteeng000 igniteeng000 reopened this Apr 7, 2019
@avsingh999
Copy link
Member

@igniteeng000 Can you please post a Screenshot/gif.
thanks : )

@igniteeng000
Copy link
Member Author

@jywarren please take a look. Thanks.

@sashadev-sky
Copy link
Member

sashadev-sky commented Apr 9, 2019

My view looks strange but one thing I do have is the layers button already

@avsingh999 can you check if your issue is still valid as you posted it 20 days ago

Chrome
mappp

Firefox
Screen Shot 2019-04-09 at 2 52 46 AM

@igniteeng000
Copy link
Member Author

yeah this issues are valid because leaflet-hash libraries are not installed by bower install.

@igniteeng000 igniteeng000 mentioned this pull request Apr 9, 2019
3 tasks
@avsingh999
Copy link
Member

avsingh999 commented Apr 11, 2019

@sashadev-sky Sorry But Now not in my local machine after pull code.
: )

@sashadev-sky
Copy link
Member

@igniteeng000 Closing this as it is no longer relevant as of your PR here: #516

Thank you for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change layer not in local machine
3 participants