Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use read only mode for database maintenance windows #2651

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Conversation

hackartisan
Copy link
Member

@hackartisan hackartisan commented Aug 12, 2021

refs #2648

Changes in this PR block database writes and update some parts of the UI where database writes would happen. The one exception is the bookmark checkboxes still appear. Clicking one brings up a modal that says "Error". It's not particularly elegant but since it doesn't crash and there's a banner message with more context I thought I'd get feedback before looking into that further.

@coveralls
Copy link

coveralls commented Aug 12, 2021

Coverage Status

Coverage increased (+0.01%) to 96.961% when pulling 681cea7 on 2648-readonly into 4de4004 on main.

@hectorcorrea
Copy link
Member

"digitization" is misspelled in the banner

banner

@hackartisan
Copy link
Member Author

"digitization" is misspelled in the banner

Thank you!!

Copy link
Member

@hectorcorrea hectorcorrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a first pass, as Anna said there are many little places where the UX will need to be improved, but that can be handled via separate and specific issues.

@christinach
Copy link
Member

Who will have the responsibility to switch the catalog in the read only mode during a database maintenance window?

@pulbot pulbot temporarily deployed to qa August 12, 2021 20:11 Inactive
@hackartisan hackartisan merged commit 8998c32 into main Aug 12, 2021
@hackartisan hackartisan deleted the 2648-readonly branch August 12, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants