Correctly set the alt type for aws_cloudwatch_log_resource_policy

[iwahbe]

This is a breaking change for Go and Typescript if users were reading the PolicyDocument field on LogResourcePolicyArgs or on LogResourcePolicy. If we don't want to take the change, we can remove the override entirely (semantically equivalent to what we have now in master).

This was discovered as part of pulumi/pulumi-terraform-bridge#1758.

[t0yv0]

I don't think this is exactly breaking as it interface{} slot would still accept string, right? So earlier programs likely still continue working.

[iwahbe]

If you write to RegistryPolicyArgs.Policy, it is not breaking. If you read from RegistryPolicyArgs.Policy, then it is breaking. I believe that writes are the common case, but you can read from args.

[t0yv0]

Yeah .. I think so. We haven't discussed how strict we want to be here, but I think we shouldn't count these changes as breaking IMO.

[t0yv0]

I'd be fine with merging because I think it won't break 99.9% of programs, curious on what @corymhall thinks. There is something really improving here for TypeScript users but not so much for Go, Go decides to emit interface{} and the typed version of the input is not discoverable.

[t0yv0]

Filed p/p enhancement around Go support.

[github-actions]

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

[github-actions]

Is README.md missing any configuration options?

assumeRoleWithWebIdentity not found in Configuration section
customCaBundle not found in Configuration section
defaultTags not found in Configuration section
ec2MetadataServiceEndpoint not found in Configuration section
ec2MetadataServiceEndpointMode not found in Configuration section
httpProxy not found in Configuration section
httpsProxy not found in Configuration section
ignoreTags not found in Configuration section
noProxy not found in Configuration section
retryMode not found in Configuration section
s3UsEast1RegionalEndpoint not found in Configuration section
sharedConfigFiles not found in Configuration section
skipRequestingAccountId not found in Configuration section
stsRegion not found in Configuration section
tokenBucketRateLimiterCapacity not found in Configuration section
useDualstackEndpoint not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.