Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove __inputs in state #2686

Closed
danielrbradley opened this issue Aug 29, 2023 · 2 comments · Fixed by #3772
Closed

Remove __inputs in state #2686

danielrbradley opened this issue Aug 29, 2023 · 2 comments · Fixed by #3772
Assignees
@EronWright
Labels
3.0 impact/breaking Fixing this issue will require a breaking change kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@danielrbradley
Copy link
Member

danielrbradley commented Aug 29, 2023 •
edited
Loading

Follow on from:

In the subsequent major release of the provider we can:

  1. Assert that the SendsOldInputs and SendsOldInputsOnDelete flags are set during configuration - failing with an error that the version of the engine must be upgraded.
  2. Remove the writing of the __inputs output property.
  3. Remove __inputs property parsing from parseCheckpointObject because old inputs is now guarenteed to be available on the gRPC request object.
@danielrbradley danielrbradley added impact/breaking Fixing this issue will require a breaking change 3.0 labels Aug 29, 2023
@danielrbradley danielrbradley mentioned this issue Aug 29, 2023
Closed
@mikhailshilkov mikhailshilkov added the kind/enhancement Improvements or new features label Aug 31, 2023
@danielrbradley danielrbradley mentioned this issue Oct 23, 2023
Merged
danielrbradley added a commit that referenced this issue Oct 24, 2023
@danielrbradley
Prefer using old inputs from the request, if available (#2775)
4d9bd40 
Fixes #2552

When using version v3.74.0 or greater of the Pulumi CLI, the `inputs`
field from the state file will be used for comparing against, rather
than the encrypted `outputs.__inputs` field. The `inputs` can safely be
edited and, until #2686 is completed, `outputs.__inputs` will be
re-generated on the next operation.

This is required when needing to prune imported resource's inputs or
edit properties which might be flagged for replacement due to a major
version upgrade.

~Currently blocked on pulumi/pulumi#14051
@cleverguy25
Copy link

Added to epic https://github.com/pulumi/home/issues/3552

@EronWright EronWright self-assigned this Dec 10, 2024
@EronWright EronWright moved this to In Progress in [Project] Azure Native V3 Dec 10, 2024
This was referenced Dec 5, 2024
Open
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in [Project] Azure Native V3 Dec 10, 2024
@pulumi-bot pulumi-bot added resolution/fixed This issue was fixed labels Dec 10, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #3772 and shipped in release v2.77.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EronWright EronWright

Labels
3.0 impact/breaking Fixing this issue will require a breaking change kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
[Project] Azure Native V3
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[v3] Remove __inputs in state pulumi/pulumi-azure-native
5 participants
@danielrbradley @mikhailshilkov @EronWright @cleverguy25 @pulumi-bot