Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove V2 code #3754

Open
2 tasks
EronWright opened this issue Dec 5, 2024 · 0 comments
Open
2 tasks

Remove V2 code #3754

EronWright opened this issue Dec 5, 2024 · 0 comments
Labels
3.0 kind/engineering Work that is not visible to an external user

Comments

@EronWright
Copy link
Contributor

EronWright commented Dec 5, 2024

This ticket tracks the (eventual) removal of "v2" code from the codebase. We may act on this once we're confident that no more 2.x builds would be needed (e.g. for a security patch) from the master branch. Consider making a "2.x" branch beforehand as a best practice.

Specifics:

@EronWright EronWright added 3.0 kind/engineering Work that is not visible to an external user labels Dec 5, 2024
EronWright added a commit that referenced this issue Dec 10, 2024
This PR implements the next stage of removing the `__inputs` from state.
In this stage, the provider has "v2" and "v3" behavior. In "v2" mode,
the behavior is unchanged. In "v3" mode, `Configure` asserts that the
engine is passing the old inputs, and doesn't write `__inputs` to state.
The fallback code that reads the `__inputs` from state is effectively
inoperative in the "v3" mode.

Added a line item to this ticket for the final phase which is to remove
the "v2" code:
#3754

Closes #2686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

1 participant