-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test TestAccSimpleTs is flaky #3813
Comments
ProgramTest runs
WebApp and WebAppSlot compete for
The reason we're not seeing more changes in the preview is that there already are some const appService = new web.WebApp("app", {
resourceGroupName: resourceGroup.name,
serverFarmId: appServicePlan.id,
kind: "app",
siteConfig: {
appSettings: [{
name: "test",
value: "this is a slot setting",
}],
},
// Subnet is associated by WebAppSwiftVirtualNetworkConnection below, so it should be ignored here to avoid
// overrides on refresh-update cycles.
// SiteConfig is modified outside of this resource via the WebApp* resources.
}, { ignoreChanges: ["virtualNetworkSubnetId", "siteConfig", "siteConfig.*"] });
const slot = new web.WebAppSlot("slot", {
resourceGroupName: resourceGroup.name,
name: appService.name,
// Subnet is associated by WebAppSwiftVirtualNetworkConnection, so it should be ignored here to avoid
// overrides on refresh-update cycles.
}, { ignoreChanges: ["virtualNetworkSubnetId"] }); |
Hopefully fix the very flaky test TestAccSimpleTs. Fixes #3813. I ran this version of the test in a loop and it succeeded 16 times in a row (each run is 5-6 minutes). Commits are logically separate: - **Update examples to latest p/p** - **Show diff when test fails preview** - **WebAppSlot bugfix: look up correct resource. Most likely had no impact.** - **Update ignoreChanges for siteConfig in WebApp/WebAppSlot to ensure proper handling of site configuration during refresh-update cycles.**
This issue has been addressed in PR #3830 and shipped in release v2.81.0. |
The text was updated successfully, but these errors were encountered: