Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestAccSimpleTs test #3830

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Fix flaky TestAccSimpleTs test #3830

merged 5 commits into from
Jan 2, 2025

Conversation

thomas11
Copy link
Contributor

@thomas11 thomas11 commented Jan 2, 2025

Hopefully fix the very flaky test TestAccSimpleTs. Fixes #3813.

I ran this version of the test in a loop and it succeeded 16 times in a row (each run is 5-6 minutes).

Commits are logically separate:

  • Update examples to latest p/p
  • Show diff when test fails preview
  • WebAppSlot bugfix: look up correct resource. Most likely had no impact.
  • Update ignoreChanges for siteConfig in WebApp/WebAppSlot to ensure proper handling of site configuration during refresh-update cycles.

@thomas11 thomas11 requested review from danielrbradley and a team January 2, 2025 16:23
Copy link

github-actions bot commented Jan 2, 2025

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link
Member

@mjeffryes mjeffryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/simple/index.ts Show resolved Hide resolved
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.01%. Comparing base (7555e20) to head (14589ea).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...der/pkg/resources/customresources/custom_webapp.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3830   +/-   ##
=======================================
  Coverage   57.01%   57.01%           
=======================================
  Files          78       78           
  Lines       12041    12041           
=======================================
  Hits         6865     6865           
  Misses       4676     4676           
  Partials      500      500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11 thomas11 enabled auto-merge (squash) January 2, 2025 17:16
@thomas11 thomas11 merged commit 61a8258 into master Jan 2, 2025
23 checks passed
@thomas11 thomas11 deleted the tkappler/webappslot-fixes branch January 2, 2025 17:49
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v2.81.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration test TestAccSimpleTs is flaky
3 participants