-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky TestAccSimpleTs test #3830
Conversation
…oper handling of site configuration during refresh-update cycles.
Does the PR have any schema changes?Looking good! No breaking changes found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3830 +/- ##
=======================================
Coverage 57.01% 57.01%
=======================================
Files 78 78
Lines 12041 12041
=======================================
Hits 6865 6865
Misses 4676 4676
Partials 500 500 ☔ View full report in Codecov by Sentry. |
This PR has been shipped in release v2.81.0. |
Hopefully fix the very flaky test TestAccSimpleTs. Fixes #3813.
I ran this version of the test in a loop and it succeeded 16 times in a row (each run is 5-6 minutes).
Commits are logically separate: