Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to remove issues with type/more commands #131

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

trevor-vaughan
Copy link
Contributor

  • Second cut at fixing support for newer versions of Windows
  • Windows updates
    • Update to use file_contents_on instead of calling out to either 'type'
      or 'more'
    • Reboot if puppet is not in the system PATH

* Second cut at fixing support for newer versions of Windows
* Windows updates
  * Update to use file_contents_on instead of calling out to either 'type'
    or 'more'
  * Reboot if puppet is not in the system PATH
@trevor-vaughan trevor-vaughan requested a review from a team February 10, 2020 02:06
@trevor-vaughan
Copy link
Contributor Author

@genebean This requires voxpupuli/beaker#1622 to function properly

Copy link
Contributor

@genebean genebean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending voxpupuli/beaker#1622

@genebean
Copy link
Contributor

@gimmyxd Does this look okay to you?

@trevor-vaughan
Copy link
Contributor Author

o_O How on earth did this pass tests without voxpupuli/beaker#1622

@gimmyxd
Copy link
Contributor

gimmyxd commented Feb 11, 2020

This has passed our acceptance suite in combination with: voxpupuli/beaker#1622

image

@genebean genebean merged commit 34312ae into puppetlabs:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants