Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support in host_helpers #1622

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Windows support in host_helpers #1622

merged 1 commit into from
Feb 13, 2020

Conversation

trevor-vaughan
Copy link
Contributor

  • Add Windows support to:
    • file_exists_on
    • directory_exists_on
    • link_exists_on (fallback to file_exists_on)
    • file_contents_on
  • Expand windows environment variables on scp_from and scp_to

@trevor-vaughan trevor-vaughan mentioned this pull request Feb 10, 2020
Merged
gimmyxd
gimmyxd previously requested changes Feb 10, 2020
View reviewed changes
lib/beaker/ssh_connection.rb Outdated Show resolved Hide resolved
@mihaibuzgau
Copy link
Contributor

The tests that are failing seem to be unrelated to this PR.

@mihaibuzgau mihaibuzgau reopened this Feb 10, 2020
@trevor-vaughan
Copy link
Contributor Author

This appears to be working as expected now

@gimmyxd
Copy link
Contributor

gimmyxd commented Feb 11, 2020

@puppetlabs-jenkins retest this please

@gimmyxd
Copy link
Contributor

gimmyxd commented Feb 11, 2020 •
edited
Loading

I've run puppet-agent ad-hoc for master with this and puppetlabs/beaker-puppet#131. Seems fine on our side
image

But beaker is extensively used on other projects, like PE testing and maybe some modules. Can someone from @puppetlabs/installer-and-management and @puppetlabs/content @puppetlabs/modules asset impact of this on their side?

@gimmyxd gimmyxd self-requested a review February 11, 2020 12:06
@genebean
Copy link
Contributor

The failing check seems to be related to a master platform. I have pinged the team I think that needs to look at that in Slack and will follow up when they are online later today.

@genebean
Copy link
Contributor

The modules team no longer uses Beaker so they have no objection to this moving forward (they have moved to Litmus).

@cthorn42
Copy link
Contributor

Sorry, looks like the configuration for the testing of PE is a bit out of date. I'm going to go ahead and approve the PR and try to fix up that configuration out of band.

@trevor-vaughan
Copy link
Contributor Author

@cthorn42 Hold on the merge please. I just found an issue with reading alternate data streams. Will have it fixed soon.

@trevor-vaughan
Windows support in host_helpers
34b0073 
* Add Windows support to:
  * file_exists_on => With Alternate Data Streams support!
  * directory_exists_on
  * link_exists_on (fallback to file_exists_on)
  * file_contents_on => With Alternate Data Streams support!
* Add 'win_ads_path' function that splits a path into the base path and
  alternate data streams
* Migrate most windows commands to Powershell
* Expand windows environment variables on scp_from and scp_to
@trevor-vaughan
Copy link
Contributor Author

@genebean and @cthorn42 This should be OK now. I had to rework some stuff in Powershell to get the ADS support working but it appears to work like a charm now.

@gimmyxd
Copy link
Contributor

gimmyxd commented Feb 13, 2020

👍 tested again with puppet-agent ad-hoc
image

@genebean genebean merged commit ccdba6c into voxpupuli:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthorn42 cthorn42 cthorn42 approved these changes

@gimmyxd gimmyxd gimmyxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trevor-vaughan @mihaibuzgau @gimmyxd @genebean @cthorn42