(MODULES-11424) Fix requirement method #287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to this PR : #283
Having discussed this subject on puppet slack, it is recommended to use require_relative for this purpose.
The problem
require fails to find the path because of concatenation.
The cause
This fix : 2e11fe6
The thing is "Pathname" override the behavior of the "+" sign to handle the missing "/" in the path ( https://ruby-doc.org/stdlib-2.6.3/libdoc/pathname/rdoc/Pathname.html#method-i-2B )
The fix
As mentionned, it is recommended to use
require_relative