-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some variables and logic surrounding the values of variables to hiera yaml files #147
Conversation
rsync::server is a classBreaking changes to this file WILL impact these 2 modules (exact match):Breaking changes to this file MAY impact these 2 modules (near match):This module is declared in 31 of 579 indexed public
|
072387c
to
a2d2ccd
Compare
I apologize sincerely for all of the noise trying to submit these changes. I'm no Puppet developer and Travis is something I have yet to understand. |
a2d2ccd
to
8d2f026
Compare
4c9e7cc
to
b533cc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This looks nice. Let me leave Just one suggestion.
# variable is defined (the variable is defined in the hiera hierarchy), then install the package. | ||
if $package_name { | ||
package {$package_name: | ||
ensure => $rsync::package_ensure, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we also want to expose this as a parameter ?
Yes, I'd do that but I suggest exposing the parameter in another pull request to keep the changes small. |
It's been about 9 months since I submitted this. Can someone please review and approve? |
I think it makes sense to move all of these if checks out to Hiera structured data.