Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some variables and logic surrounding the values of variables to hiera yaml files #147

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

bschonec
Copy link
Contributor

I think it makes sense to move all of these if checks out to Hiera structured data.

@bschonec bschonec requested a review from a team as a code owner July 13, 2022 18:19
@puppet-community-rangefinder
Copy link

rsync::server is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 31 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2022

CLA assistant check
All committers have signed the CLA.

@bschonec bschonec force-pushed the hierify_variables branch from 072387c to a2d2ccd Compare July 13, 2022 18:57
@bschonec
Copy link
Contributor Author

I apologize sincerely for all of the noise trying to submit these changes. I'm no Puppet developer and Travis is something I have yet to understand.

@bschonec bschonec force-pushed the hierify_variables branch from a2d2ccd to 8d2f026 Compare July 13, 2022 19:04
@bschonec bschonec force-pushed the hierify_variables branch from 4c9e7cc to b533cc6 Compare July 26, 2022 11:41
Copy link
Collaborator

@kajinamit kajinamit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks nice. Let me leave Just one suggestion.

# variable is defined (the variable is defined in the hiera hierarchy), then install the package.
if $package_name {
package {$package_name:
ensure => $rsync::package_ensure,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also want to expose this as a parameter ?

@bschonec
Copy link
Contributor Author

Yes, I'd do that but I suggest exposing the parameter in another pull request to keep the changes small.

@bschonec
Copy link
Contributor Author

It's been about 9 months since I submitted this. Can someone please review and approve?

@kajinamit kajinamit merged commit 771aa03 into puppetlabs:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants