Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add Integration Time Setting/Getting to Optical #481

Merged
merged 3 commits into from
Jan 25, 2023
Merged

✨ Add Integration Time Setting/Getting to Optical #481

merged 3 commits into from
Jan 25, 2023

Conversation

WillXuCodes
Copy link
Member

@WillXuCodes WillXuCodes commented Dec 17, 2022 •
edited
Loading

Summary:

Added Integration Time Setting/Getting to Optical, C and C++, bounds are 712 ms max and 3 ms min.

References:

#473

Test Suace:

  • Set Integration to something reasonable (20 ms)
  • Set Integration to something too low (2 ms)
  • Set Integration to something reasonable (713 ms)
  • Get Integration time before setting sensor (no set)
  • Get Integration time after setting sensor (20 ms set)
  • Drink ranch

@WillXuCodes WillXuCodes changed the title ✨ Added Integration Time Setting/Getting to Optical ✨ Add Integration Time Setting/Getting to Optical Jan 12, 2023
BennyBot
BennyBot approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@BennyBot BennyBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on hardware and appears to be working.

@WillXuCodes WillXuCodes merged commit d4d2752 into develop Jan 25, 2023
@WillXuCodes WillXuCodes deleted the feature/optical-integration-time branch March 8, 2023 05:43
@Gracelu128 Gracelu128 mentioned this pull request Sep 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BennyBot BennyBot BennyBot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WillXuCodes @BennyBot @aaryan-gautam