Skip to content

Commit

Permalink
fix(multipath): remove dependency on multipathd.socket
Browse files Browse the repository at this point in the history
This reverts commit e39ff40, removes
an incorrect `Also=` directive from multipathd.service.

`Also=multipathd.socket` is not the correct behavior for a
socket-activated service. This directive has been removed upstream
and dracut should do the same.

This fixes dracutdevs#2289, dracutdevs#2175 where in the cleanup hook running multipath
binary triggers activation of multipathd.service after it is stopped
as dracut prepares to switch root in initrd-cleanup.service.
  • Loading branch information
cthbleachbit authored and pvalena committed Jul 23, 2023
1 parent 909c4d7 commit b59cece
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion modules.d/90multipath/module-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ install() {
inst_simple "${moddir}/multipathd-configure.service" "${systemdsystemunitdir}/multipathd-configure.service"
$SYSTEMCTL -q --root "$initdir" enable multipathd-configure.service
fi
inst_simple "${systemdsystemunitdir}/multipathd.socket"
inst_simple "${moddir}/multipathd.service" "${systemdsystemunitdir}/multipathd.service"
$SYSTEMCTL -q --root "$initdir" enable multipathd.service
else
Expand Down
1 change: 0 additions & 1 deletion modules.d/90multipath/multipathd.service
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,3 @@ TasksMax=infinity

[Install]
WantedBy=sysinit.target
Also=multipathd.socket

0 comments on commit b59cece

Please sign in to comment.