Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multipath boot hangs with dracut-059 #2175

Closed
aafeijoo-suse opened this issue Jan 26, 2023 · 4 comments
Closed

multipath boot hangs with dracut-059 #2175

aafeijoo-suse opened this issue Jan 26, 2023 · 4 comments
Labels
bug Our bugs debian Issue tracker for the Debian distribution multipath Issues related to the multipath module opensuse Issue tracker for the OpenSuse distribution regression

Comments

@aafeijoo-suse
Copy link
Member

aafeijoo-suse commented Jan 26, 2023 •
edited
Loading

Describe the bug
Multipath is broken due to 02e646f

Distribution used
openSUSE Tumbleweed

Dracut version
059-358-g8ecd6e83

Init system
systemd 252.4

To Reproduce

  1. Create a multipath setup
  2. Try to boot the system

Additional context
After creating an initrd without including multipathd.socket, the system boots.
The definition of multipathd.service does not suggest that the inclusion is wrong:

dracut/modules.d/90multipath/multipathd.service

Line 7 in 3c16c76

After=multipathd.socket systemd-remount-fs.service

dracut/modules.d/90multipath/multipathd.service

Line 28 in 3c16c76

Also=multipathd.socket

I'm not sure if this only affects openSUSE Tumbleweed, or if others are affected as well.

Edit: 02e646f reverted in 059+suse.360.g2e0ed5f7, so multipath works again in openSUSE Tumbleweed.
@aafeijoo-suse aafeijoo-suse added the bug Our bugs label Jan 26, 2023
@aafeijoo-suse
Copy link
Member Author

CC: @cthbleachbit, what was your reasoning behind your change, only the multipathd.service definition? did you try it?

@cthbleachbit
Copy link
Contributor

When I proposed that fix, the service defenition required the socket to present. Otherwise systemd would refused to enable the unit.

I tried masking the socket unit again and this time systemd gives Failed to enable auxiliary unit multipathd.socket, ignoring., which seems to suggest that systemd behavior had changed for a newer version and a missing socket definition is no longer fatal...

I'm not sure why including socket definition cause the service to hang in SUSE though. On my computer, multipathd did start normally in dracut environment. I should probably try to get suse in a VM and see what's going on

@aafeijoo-suse
Copy link
Member Author

Good, thanks for your feedback. I just wanted to know if this is a SUSE-only issue.

@LaszloGombos LaszloGombos added multipath Issues related to the multipath module regression opensuse Issue tracker for the OpenSuse distribution labels Jan 27, 2023
@LaszloGombos LaszloGombos mentioned this issue Mar 6, 2023
Closed
@LaszloGombos LaszloGombos added the debian Issue tracker for the Debian distribution label Mar 6, 2023
@LaszloGombos LaszloGombos mentioned this issue Mar 25, 2023
Closed
@cthbleachbit cthbleachbit mentioned this issue Mar 25, 2023
Merged
3 tasks
aafeijoo-suse pushed a commit that referenced this issue Apr 11, 2023
@cthbleachbit @aafeijoo-suse
fix(multipath): remove dependency on multipathd.socket
297525c 
This reverts commit e39ff40, removes
an incorrect `Also=` directive from multipathd.service.

`Also=multipathd.socket` is not the correct behavior for a
socket-activated service. This directive has been removed upstream
and dracut should do the same.

This fixes #2289, #2175 where in the cleanup hook running multipath
binary triggers activation of multipathd.service after it is stopped
as dracut prepares to switch root in initrd-cleanup.service.
@aafeijoo-suse
Copy link
Member Author

Fixed by #2290

aafeijoo-suse pushed a commit to aafeijoo-suse/dracut that referenced this issue Jun 15, 2023
@cthbleachbit @aafeijoo-suse
fix(multipath): remove dependency on multipathd.socket
fa0d531 
This reverts commit e39ff40, removes
an incorrect `Also=` directive from multipathd.service.

`Also=multipathd.socket` is not the correct behavior for a
socket-activated service. This directive has been removed upstream
and dracut should do the same.

This fixes dracutdevs#2289, dracutdevs#2175 where in the cleanup hook running multipath
binary triggers activation of multipathd.service after it is stopped
as dracut prepares to switch root in initrd-cleanup.service.

(cherry picked from commit 297525c)
pvalena pushed a commit to pvalena/dracut that referenced this issue Jul 23, 2023
@cthbleachbit @pvalena
fix(multipath): remove dependency on multipathd.socket
b59cece 
This reverts commit e39ff40, removes
an incorrect `Also=` directive from multipathd.service.

`Also=multipathd.socket` is not the correct behavior for a
socket-activated service. This directive has been removed upstream
and dracut should do the same.

This fixes dracutdevs#2289, dracutdevs#2175 where in the cleanup hook running multipath
binary triggers activation of multipathd.service after it is stopped
as dracut prepares to switch root in initrd-cleanup.service.
imguoguo pushed a commit to fedora-riscv/dracut that referenced this issue May 30, 2024
@mh21
Backport fix to remove dependency on multipathd.socket
a2c4179 
Fixes boot hangs on s390x/multipath.

- dracutdevs/dracut#2175
- dracutdevs/dracut#2289
- dracutdevs/dracut#2318
imguoguo pushed a commit to fedora-riscv/dracut that referenced this issue May 30, 2024
@mh21
Backport fix to remove dependency on multipathd.socket
fb0a5db 
Fixes boot hangs on s390x/multipath.

- dracutdevs/dracut#2175
- dracutdevs/dracut#2289
- dracutdevs/dracut#2318
imguoguo pushed a commit to fedora-riscv/dracut that referenced this issue May 30, 2024
@mh21
Backport fix to remove dependency on multipathd.socket
7f42ff8 
Fixes boot hangs on s390x/multipath.

- dracutdevs/dracut#2175
- dracutdevs/dracut#2289
- dracutdevs/dracut#2318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Our bugs debian Issue tracker for the Debian distribution multipath Issues related to the multipath module opensuse Issue tracker for the OpenSuse distribution regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LaszloGombos @cthbleachbit @aafeijoo-suse