Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Updates: Code coverage report, Ubuntu 24.04, PETSc 3.22 #443

Merged
merged 47 commits into from
Feb 5, 2025

Conversation

kvrigor
Copy link
Member

@kvrigor kvrigor commented Oct 2, 2024

Summary of changes:

  • Integrated Codacy reporting.
  • Locked runner versions to ubuntu-24.04 and macos-14. The *-latest runner versions are moving targets; we wish to avoid surprise failing tests caused by runner upgrades (e.g. see macOS issue from last year) .
  • Upgraded PETSc to v3.22.

@kvrigor
Copy link
Member Author

kvrigor commented Oct 3, 2024

Codacy integration seems working. Link to report: https://app.codacy.com/gh/pyccel/psydac/coverage?branch=codacy-codecov

Copy link

codacy-production bot commented Oct 4, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 5ff38841
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5ff3884) Report Missing Report Missing Report Missing
Head commit (4c445fa) 61320 36792 60.00%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#443) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kvrigor kvrigor changed the title Codacy codecov Codacy code coverage reporting Oct 4, 2024
@kvrigor
Copy link
Member Author

kvrigor commented Oct 4, 2024

Detailed coverage results are also shown in CI: https://github.com/pyccel/psydac/actions/runs/11180714225/job/31083050038?pr=443#step:22:20

@kvrigor kvrigor marked this pull request as ready for review October 4, 2024 14:19
@kvrigor kvrigor requested a review from yguclu October 4, 2024 14:19
@yguclu
Copy link
Member

yguclu commented Oct 7, 2024

The single-process tests on Ubuntu with Python 3.12 are taking almost one hour and a half to run. This does not happen with the other jobs. Do you see a reason for this?

All single process tests will still be run regardless
of test order; thus we don't really reduce test time.
@kvrigor kvrigor marked this pull request as ready for review October 24, 2024 16:29
@kvrigor
Copy link
Member Author

kvrigor commented Oct 24, 2024

@campospinto's suggestion is neat! coverage now runs only on macOS and the Ubuntu test time is back to normal. This PR is ready for review.

yguclu
yguclu previously requested changes Oct 24, 2024
Copy link
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I have some questions below.

By the way, I thought you wanted to use Pytest's cache to run the failed tests first. Have you abandoned the idea?

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@kvrigor kvrigor requested a review from yguclu November 6, 2024 11:02
@yguclu yguclu added the urgent PR should be merged ASAP label Nov 20, 2024
@kvrigor
Copy link
Member Author

kvrigor commented Jan 15, 2025

Update 15.01.2025: I'm piggybacking these changes into this PR:

  • Locked runner versions to ubuntu-24.04 and macos-14. The *-latest runner versions are moving targets; we wish to avoid surprise failing tests caused by runner upgrades (e.g. see macOS issue from last year) .
  • Upgraded PETSc to v3.22.

@kvrigor kvrigor changed the title Codacy code coverage reporting CI Updates: Code coverage report, Ubuntu 24.04, PETSc 3.22 Jan 15, 2025
Copy link

codacy-production bot commented Jan 15, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 74c12711
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (74c1271) Report Missing Report Missing Report Missing
Head commit (83a8679) 61326 36798 60.00%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#443) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kvrigor kvrigor requested a review from campospinto January 15, 2025 10:49
Copy link
Collaborator

@campospinto campospinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have general objections for this PR

Copy link
Collaborator

@campospinto campospinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversations seem to be resolved so I'll approve

@campospinto campospinto dismissed yguclu’s stale review February 5, 2025 13:45

Because he asked me so

@campospinto
Copy link
Collaborator

Thanks Paul 👍

@yguclu yguclu merged commit 66205a5 into devel Feb 5, 2025
8 checks passed
@yguclu yguclu deleted the codacy-codecov branch February 5, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urgent PR should be merged ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants