Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix bug gmres" #454

Closed
wants to merge 2 commits into from
Closed

Revert "fix bug gmres" #454

wants to merge 2 commits into from

Conversation

campospinto
Copy link
Collaborator

Reverts #452 to fix the failing tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This reverts commit 74c1271.
@kvrigor
Copy link
Member

kvrigor commented Jan 22, 2025

The CI failure is related to the recent Ubuntu 24.04 runner upgrade and has been fixed in this PR: #443

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

codacy-production bot commented Feb 12, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5669252) 30703 18443 60.07%
Head commit (101ab19) 61400 (+30697) 36880 (+18437) 60.07% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#454) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@yguclu
Copy link
Member

yguclu commented Feb 12, 2025

@kvrigor Do you mean that this PR is no longer needed?

@kvrigor
Copy link
Member

kvrigor commented Feb 12, 2025

@kvrigor Do you mean that this PR is no longer needed?

I was suggesting to merge the recent CI fix from devel to solve the test issues. Not sure about the necessity of the PR itself though

@campospinto
Copy link
Collaborator Author

@kvrigor Do you mean that this PR is no longer needed?

I was suggesting to merge the recent CI fix from devel to solve the test issues. Not sure about the necessity of the PR itself though

I'm also not convinced that this PR is needed:

@yguclu
Copy link
Member

yguclu commented Feb 12, 2025

All right then! I am closing this PR as no longer needed.

@yguclu yguclu closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants