Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In mobile the navigation menu does not open #25

Closed
datapythonista opened this issue Oct 5, 2019 · 4 comments · Fixed by pandas-dev/pandas#28940
Closed

In mobile the navigation menu does not open #25

datapythonista opened this issue Oct 5, 2019 · 4 comments · Fixed by pandas-dev/pandas#28940

Comments

@datapythonista
Copy link
Member

In mobile, the menu is collapsed in the square with the three horizontal lines. When clicked, it should expand and show the menu, but it doesn't.

If complex, probably not worth fixing, if we plan to use the same navigation and layout as for the web.

@jorisvandenbossche
Copy link
Member

Hmm, this only seems to be the case on an actual phone. The responsive design mode (at least in firefox) is working fine for me. Thanks for noticing!

@jorisvandenbossche
Copy link
Member

I was looking at the wrong one, I was testing https://dev.pandas.io/pandas-sphinx-theme/ (the test version), and that one is also working fine on a mobile phone.
So there is something wrong with how we apply the theme in pandas (some css or javascript might be missing).

@jorisvandenbossche
Copy link
Member

On the pandas dev site, there is a javascript error related to jquery (and I suppose for that reason no javascript is working). This one is included by sphinx, and the pandas dev site is built with an older version of sphinx. So let's see if upgrading sphinx helps (and we should maybe reconsider if we want jquery to be linked with the sphinx version, or include it ourselves)

@jorisvandenbossche
Copy link
Member

In the end, this seemed to be caused by a new release of nbsphinx, which started to include require.js, which then broke the javascript of bootstrap.
This is fixed in 32e12de to instruct nbsphinx to not include require.js. And opening #30 for the general issue to be compatible with require.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants