-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to include require.js #327
Conversation
@manycoding This reverts your PR #302, can you please check if this still works for you? |
Works like a charm. |
@manycoding Thanks for testing! |
@mgeier Would it be an option to disable this by default? I know you can now disable it by setting I suppose there will be a way to let requirejs and bootstrap talk nicely together, but not by using it in the default way (including the bootstrap.js in a script tag). So eg websites using sphinx-bootstrap-theme, and both scikit-learn and pandas also recently started to use bootstrap in their development version (it's on the pandas docs that I notices javascript was broken recently, after the nbsphinx update) |
In general, sure. Currently, it is enabled by default because Plotly plots needed it, see #128 and #302. Also, it is loaded in the Classic Notebook, in JupyterLab and in
That would be nice.
Can you please describe the problem? There is a version of the |
I've found the Pandas issues: |
@mgeier Thanks for the answer! I don't directly see the problem happening at https://nbsphinx.readthedocs.io/en/bootstrap-theme/, would need to look more into it to understand the difference (but this week on a work week, will try to check next week) |
I have the gut feeling that it is related to the bootstrap versions. |
Ah, possibly yes. In any case we are using Bootstrap 4. |
No description provided.