Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: ensure to play nicely with require.js #30

Closed
jorisvandenbossche opened this issue Oct 12, 2019 · 3 comments
Closed

ENH: ensure to play nicely with require.js #30

jorisvandenbossche opened this issue Oct 12, 2019 · 3 comments
Labels
needs: more information Needs more information from the author before we can move forward

Comments

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Oct 12, 2019

If you need require.js, or there is some other extension that includes require.js (the example case was nbsphinx including require.js, see #25, 32e12de), then that breaks all javascript ("Error: Mismatched anonymous define() module:").

I suppose there are ways to let bootstrap and requirejs (if included) play nicely together.

@choldgraf
Copy link
Collaborator

It seems like this blog post:

https://getfishtank.ca/blog/how-to-use-bootstrap-3-with-requirejs

suggests that you can load bootstrap using requirejs. This is maybe a heavy-weight option, but one idea is to either load RequireJS with the theme, or to add an option to do so...

@12rambau
Copy link
Collaborator

since 2019 the implementation of bootstrap has quite changed, is it still an issue ?

@12rambau 12rambau added the needs: more information Needs more information from the author before we can move forward label Oct 18, 2022
@12rambau
Copy link
Collaborator

solved in #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: more information Needs more information from the author before we can move forward
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants