Add a simple FileBrowser to JobCore #969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .ci_support/environment.yml # pyiron_base/jobs/job/util.py # setup.py
Also use a sub test for every line test
job[] is overloaded to perform many functions at once: 1. access to files 2. access to HDF stored data 3. access to child jobs This change adds a new attribute `.files` to `JobCore` to take over function 1 and deprecates methods on the job itself that are connected to this: `list_files` and `tail`.
|
Eh, I've borking my starting point, there relevant changes are in this commit. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
job[] is overloaded to perform many functions at once:
1. access to files
2. access to HDF stored data
3. access to child jobs
This change adds a new attribute
.filestoJobCoreto take overfunction 1 and deprecates methods on the job itself that are connected
to this:
list_filesandtail.One of the problems we had discussed in the strategy meeting was that indexing notation is inconsistent and I think that this multiplexing of responsibilities is one of the reasons why
job[]is inconsistent.I'm thinking therefor to introduce attributes for all three responsibilities (actually job.content works already well for 2.) and then deprecate
job[]completely or at least agree on which of the three it should do.Depends on #894