Upgrade pre-commit tools and fix existing issue #10165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Maintenance
Pierre-Sassoulas
force-pushed
the
pre-commit-upgrade
branch
2 times, most recently
from
9542683 to
d27a5bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #10165 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 174 174
Lines 18976 18976
=======================================
Hits 18180 18180
Misses 796 796
|
Pierre-Sassoulas
force-pushed
the
pre-commit-upgrade
branch
from
d27a5bb to
3e07f8c
Compare
|
Current theory is that w never had nothing merged in the main branch for such a long time so we have missing file / cache issue that could be resolved by just merging this and rebasing. (But it's a great occasion to fix the underlying issue). |
jacobtylerwalls
approved these changes
Jan 3, 2025
| @@ -22,7 +22,9 @@ class TestDialect(csv.excel): | |||
| delimiter = ":" | |||
| lineterminator = "\n" | |||
|
|
|||
| csv.register_dialect("test", TestDialect) | |||
| # TestDialect inherit from csv.excel, which inherit from Dialect | |||
| # probably something wrong in csv typing | |||
There was a problem hiding this comment.
I already fixed this in typeshed, sorry I didn't follow up with an ignore :-)
There was a problem hiding this comment.
Fixing the collections.abc bug was the priority back then :) !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This fix the main branch.