Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pre-commit tools and fix existing issue #10165

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Upgrade pre-commit tools and fix existing issue #10165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pylint/testutils/functional/lint_module_output_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ class TestDialect(csv.excel):
delimiter = ":"
lineterminator = "\n"

csv.register_dialect("test", TestDialect)
# TestDialect inherit from csv.excel, which inherit from Dialect
# probably something wrong in csv typing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already fixed this in typeshed, sorry I didn't follow up with an ignore :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the collections.abc bug was the priority back then :) !

csv.register_dialect("test", TestDialect) # type: ignore[arg-type]

def _check_output_text(
self,
Expand Down
Loading