Move TestVariablesChecker to functional tests

tests/functional/a/access/access_member_before_definition.py

@@ -1,11 +1,12 @@
 # pylint: disable=missing-docstring,too-few-public-methods,invalid-name
 # pylint: disable=attribute-defined-outside-init, useless-object-inheritance
 
+
 class Aaaa(object):
     """class with attributes defined in wrong order"""
 
     def __init__(self):
-        var1 = self._var2 # [access-member-before-definition]
+        var1 = self._var2  # [access-member-before-definition]
         self._var2 = 3
         self._var3 = var1
 
@@ -21,20 +22,26 @@ def __getattr__(self, attr):
             self.__repo = attr
             return attr
 
-
     def catchme(self, attr):
         """no AttributeError caught"""
         try:
-            return self._repo # [access-member-before-definition]
+            return self._repo  # [access-member-before-definition]
         except ValueError:
             self._repo = attr
             return attr
 
 
 class Mixin(object):
-
     def test_mixin(self):
         """Don't emit access-member-before-definition for mixin classes."""
         if self.already_defined:
             # pylint: disable=attribute-defined-outside-init
             self.already_defined = None
+
+
+# Test for regression in bitbucket issue 164
+# https://bitbucket.org/logilab/pylint/issue/164/
+class MyClass1:
+    def __init__(self):
+        self.first += 5  # [access-member-before-definition]
+        self.first = 0

tests/functional/a/access/access_member_before_definition.txt

@@ -1,2 +1,3 @@
-access-member-before-definition:8:15:8:25:Aaaa.__init__:Access to member '_var2' before its definition line 9:UNDEFINED
+access-member-before-definition:9:15:9:25:Aaaa.__init__:Access to member '_var2' before its definition line 10:UNDEFINED
 access-member-before-definition:28:19:28:29:Bbbb.catchme:Access to member '_repo' before its definition line 30:UNDEFINED
+access-member-before-definition:46:8:46:18:MyClass1.__init__:Access to member 'first' before its definition line 47:UNDEFINED

tests/functional/m/method_hidden.py

@@ -1,30 +1,38 @@
 # pylint: disable=too-few-public-methods, useless-object-inheritance,missing-docstring
+# pylint: disable=unused-private-member
 """check method hidding ancestor attribute
 """
 from __future__ import print_function
 
+
 class Abcd(object):
     """dummy"""
+
     def __init__(self):
         self.abcd = 1
 
+
 class Cdef(Abcd):
     """dummy"""
-    def abcd(self): # [method-hidden]
-        """test
-        """
+
+    def abcd(self):  # [method-hidden]
+        """test"""
         print(self)
 
+
 class AbcdMixin:
     def abcd(self):
         pass
 
+
 class Dabc(AbcdMixin, Abcd):
     def abcd(self):
         pass
 
+
 class CustomProperty:
     """dummy"""
+
     def __init__(self, _):
         pass
 
@@ -36,8 +44,10 @@ def __get__(self, obj, __):
     def __set__(self, _, __):
         pass
 
+
 class Ddef:
     """dummy"""
+
     def __init__(self):
         self.five = "five"
 
@@ -73,13 +83,15 @@ def __init__(self, one=None):
         if one is not None:
             self.one = one
 
-    def one(self): # [method-hidden]
+    def one(self):  # [method-hidden]
         pass
 
+
 class Two(One):
     def one(self):
         pass
 
+
 try:
     import unknown as js
 except ImportError:
@@ -90,3 +102,23 @@ class JsonEncoder(js.JSONEncoder):
     # pylint: disable=useless-super-delegation,super-with-arguments
     def default(self, o):
         return super(JsonEncoder, self).default(o)
+
+
+class Parent:
+    def __init__(self):
+        self._protected = None
+
+
+class Child(Parent):
+    def _protected(self):  # [method-hidden]
+        pass
+
+
+class ParentTwo:
+    def __init__(self):
+        self.__private = None
+
+
+class ChildTwo(ParentTwo):
+    def __private(self):
+        pass